-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OC-924: Allow ECS task to be triggerable on demand #737
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice way to do this, good job 👍
Curious thought, does Octopus have an admin area? |
Not as yet though, but can see how this would slot into that if it did exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though a few optimisations could be made to the order of events in the authentication middleware
The purpose of this PR was to build on the proof of concept ECS task and allow it to be triggerable on demand. This is because we want to use ECS to run incremental ARI imports that are triggerable by a non-dev with an API key.
This also involved removing the
services.tf
file because we actually didn't need a service in the first place. That is more for maintaining open-ended tasks while we just want one-off executions for the time being.Also cherry-picked some UI fixes from a pending PR to get end to end tests to pass.
Acceptance Criteria:
Checklist:
Tests:
API
E2E
Screenshots:
This is the ECS task log stream in Cloudwatch after I triggered the task using the lambda function.