Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-924: Allow ECS task to be triggerable on demand #737

Merged
merged 9 commits into from
Dec 19, 2024
Merged

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to build on the proof of concept ECS task and allow it to be triggerable on demand. This is because we want to use ECS to run incremental ARI imports that are triggerable by a non-dev with an API key.

This also involved removing the services.tf file because we actually didn't need a service in the first place. That is more for maintaining open-ended tasks while we just want one-off executions for the time being.

Also cherry-picked some UI fixes from a pending PR to get end to end tests to pass.


Acceptance Criteria:

  • The proof of concept ECS task can be triggered on demand.

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

API
Screenshot 2024-12-11 161724

E2E
Screenshot 2024-12-11 160840


Screenshots:

This is the ECS task log stream in Cloudwatch after I triggered the task using the lambda function.
Screenshot 2024-12-11 152102

@finlay-jisc finlay-jisc requested a review from a team as a code owner December 11, 2024 16:25
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 4:04pm

Copy link

@adwearing-jisc adwearing-jisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice way to do this, good job 👍

@adwearing-jisc
Copy link

Curious thought, does Octopus have an admin area?

@finlay-jisc
Copy link
Collaborator Author

Curious thought, does Octopus have an admin area?

Not as yet though, but can see how this would slot into that if it did exist.

Copy link

@adwearing-jisc adwearing-jisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though a few optimisations could be made to the order of events in the authentication middleware

@finlay-jisc finlay-jisc merged commit 8bb7273 into main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants