Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-974: Enable easier searching of publications on author pages #740

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

finlay-jisc
Copy link
Collaborator

@finlay-jisc finlay-jisc commented Dec 17, 2024

The purpose of this PR was to help users find publications on author pages, now that there are more author pages with lots of publications. Before now they were all in one infinitely expanding list.

  • The API endpoint for getting a user's publications now allows filtering by a query term, and the response format has been standardised to match similar "search" style responses
  • Most of the code from SearchPage has been extracted to SearchInterface, with changes to make the search type select optional and the no results message override-able
  • Grouped up some search related components into a folder causing some renames

Acceptance Criteria:

  • The author page publication list is paginated in the same manner as the search page, with options to show 10, 20 or 50 rows on each page (20 being default), plus a total count of records, and options to view the next/previous page.
  • A search is available at the top of the publications list to find specific results

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

UI
Screenshot 2024-12-17 100950

API
Screenshot 2024-12-17 102209

E2E
Screenshot 2024-12-17 094339


Screenshots:

Screenshot 2024-12-17 103453

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
octopus ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:51am

@finlay-jisc finlay-jisc marked this pull request as ready for review December 17, 2024 10:54
@finlay-jisc finlay-jisc requested a review from a team as a code owner December 17, 2024 10:54
@finlay-jisc finlay-jisc merged commit d5c689b into main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants