Add carousel component #18
Conversation
justiniruuza
requested review from
jefrydco,
zrg-team,
nhat-ndm1193 and
sieuhuflit
and removed request for
jefrydco
example/package.json
Outdated
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx" | ||
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx", | ||
| "add-library": "yarn remove @jitera/jitera-rn-ui-library && yarn cache clean && yarn add ../", | ||
| "reset": "watchman watch-del '/Users/justinphan/www/jitera-rn-ui-library/example' ; watchman watch-project '/Users/justinphan/www/jitera-rn-ui-library/example'" |
There was a problem hiding this comment.
We can simplify the command into:
| "reset": "watchman watch-del '/Users/justinphan/www/jitera-rn-ui-library/example' ; watchman watch-project '/Users/justinphan/www/jitera-rn-ui-library/example'" | |
| "reset": "watchman watch-del-all'" |
There was a problem hiding this comment.
@jefrydco : updated
|
Anyway, In order for GitHub to able to render the preview, the format of the video should be mp4. |
|
|
||
| return ( | ||
| <View ref={ref} style={style} onLayout={handleLayout}> | ||
| <FlatList |
There was a problem hiding this comment.
it ok to use the library here, cause it has animation and something useful.
There was a problem hiding this comment.
@zrg-team You mean we can use external library rather than implementing by ourself?
There was a problem hiding this comment.
yes you can use external library
There was a problem hiding this comment.
@zrg-team: any suggestion library?
There was a problem hiding this comment.
https://github.com/meliorence/react-native-snap-carousel
i think this is the most popular lib
There was a problem hiding this comment.
There was a problem hiding this comment.
anyway, we can choose another lib, i think there are a lot library out there
There was a problem hiding this comment.
Okay if it stable then let go with this one
There was a problem hiding this comment.
Maintaining a library like this will take us a lot of time. cause requirement will have animation, etc
There was a problem hiding this comment.
@zrg-team : Updated with library above
justiniruuza
force-pushed
the
feature/create-carousel-component
branch
from
0c0076e
to
c9ca648
Compare
| {...iconSpecificStyle} | ||
| {...props} | ||
| /> | ||
| <View ref={ref} style={style}> |
There was a problem hiding this comment.
Icon component is not support ref ? then we have to wrapper ?
There was a problem hiding this comment.
Yes it has but seem not stable, sometimes it doesn't work and make project breaking. That's why I wrapped it
There was a problem hiding this comment.
ok ok. If it not stable good to go. But keep in mind, the library should have fewer components because passing props with many style objects isn't a good idea, you have more work in Jitera tool
justiniruuza
force-pushed
the
feature/create-carousel-component
branch
from
046c86c
to
e258523
Compare
justiniruuza
force-pushed
the
feature/create-carousel-component
branch
from
e258523
to
518ef8b
Compare
#Note: Please do not merge as this time. I'm working with jitera-frontend from local to make sure it work before publish
Create carousel component.
Ios Demo:
https://www.loom.com/share/13533b76cf8149029f59aa9c7a7342da