Add Magic Trackpad or Mouse upon (re)connection #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Debug build linked below (updated 2022-11-13): |
Consolidates BNBMouseDevice and BNBTrackpadDevice notifications, which do not appear on newer devices/OS versions.
Could replace familyIsBuiltinTrackpad and other functions with [NSArray containsObject:] at some point, but this would ideally require the NSArray defined as a constant literal, which requires a deployment target of macOS 11 or above. https://blog.andrewmadsen.com/2021/06/07/constant-literals-in.html https://developer.apple.com/documentation/xcode-release-notes/xcode-13-release-notes
aaronkollasch
force-pushed
the
fix/28/trackpad-reconnect
branch
from
ab24d97
to
f79f4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On recent versions of macOS, or possibly on newer Apple devices, Jitouch does not respond to a newly connected Magic Trackpad or Magic Mouse without reloading all devices.
This is because the Magic Trackpad does not show up as a
BNBTrackpadDevice, and the Magic Mouse does not show up as aBNBMouseDevicein the I/O Registry. For example, the output ofioreg -l -w 180 | grep -i BNBTrackpadDeviceis empty even with a Magic Trackpad connected.This prevents Jitouch from detecting when those devices are connected and disconnected, so it can't refresh its device list or add its callback to those devices.
Instead, Jitouch should watch for the connection of I/O devices named
AppleMultitouchDevice, which have aMultitouch IDthat corresponds to the ID produced byMTDeviceGetDeviceID, and aFamily IDthat corresponds to the output ofMTDeviceGetFamilyID. When such a device is connected, Jitouch's stored device list can be searched byMultitouch IDand the matching device stopped, before starting a new device for that ID.See the IOKitLib API and example ioreg outputs.
Fixes #28 and fixes #40 and fixes #46