-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing 2 Bugs. jitouch now works on Ventura. #51
Conversation
…es are not performed in main queue. 2. move-resize icon not changing. Ventura requires contentView's setNeedsDisplay set to YES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and for all your hard work on Jitouch! ❤️
I have one minor change, but otherwise this LGTM.
Also, the same cursorWindow
calls occur in gestureMagicMouseV()
, if you'd care to fix that as well.
https://github.com/aaronkollasch/jitouch/blob/7f860a9b69e0ccab708381403e41f361487eb9e5/jitouch/Jitouch/Gesture.m#L2335
Co-authored-by: Aaron Kollasch <aaron@kollasch.dev>
Yes, let me fix it real quick. And thank YOU too for maintaining it and keeping it alive!!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For completeness, I am adding the other @autoreleasepool
changes
I just converted the existing ones to @autoreleasepool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aaronkollasch, I use Ventura 13.4 on Mac M1, and Jitouch works fine, but the preferences pane just doesn't stay open for me to change any setting. If a fix for this issue is unknown, could you give me something like the file location of these settings, so that I can maybe create a backup of it just in case I have to format my device or install on another device with the same settings that I have right now? Screen.Recording.2023-09-03.at.12.19.27.PM.mov-5AACD356-EC5E-4F3F-8589-C8F1297DFB51.mp4 |
Hi @AJAYK-01, That looks like a crash in Jitouch's Preference Pane. Could you make a separate issue for it? The location of the settings is |
Opened #71 |
Hey @aaronkollasch thanks for the settings file location, editing it via xcode editor works! However could you also let me know where to find all the possible strings related to the trackpad gesture combinations as well as the possible actions it can do? This would help me add new gestures in the future if I needed. |
Fix 2 bugs. It's now working on Ventura.
It's been almost a decade since I last used xcode / obj-c. So, please help review the changes.