remove c++ standard from compile options and define separately to compile with clang #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with clang I ran into an issue with the specified compile options.
gcc throws a warning for this, but clang throws an error.
building with gcc:
cc1: warning: command line option ‘-std=c++14’ is valid for C++/ObjC++ but not for C
building with clang:
error: invalid argument '-std=c++14' not allowed with 'C'
By defining the c++ standard outside of compile options this warning/error is addressed and I can compile with both clang and gcc.