Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mean_stdv refactor #77

Closed
JoFrhwld opened this issue Oct 3, 2022 · 3 comments
Closed

mean_stdv refactor #77

JoFrhwld opened this issue Oct 3, 2022 · 3 comments
Labels
good first issue Easy to do and suitable for new developers refactor code refactoring

Comments

@JoFrhwld
Copy link
Owner

JoFrhwld commented Oct 3, 2022

The code in mean_stdv() should be refactored with numpy

def mean_stdv(valuelist):

@JoFrhwld JoFrhwld added the refactor code refactoring label Oct 3, 2022
@chrisbrickhouse chrisbrickhouse added the good first issue Easy to do and suitable for new developers label Oct 6, 2022
@chrisbrickhouse
Copy link
Collaborator

chrisbrickhouse commented Oct 6, 2022

Good first issue:

  • Write a test for the current output with lots of test cases
  • Remove existing code and replace with numpy calls
  • Ensure that the tests still pass, proving that the function output is identical

@DerMoehre
Copy link
Contributor

Hi,
I wrote a test for testing the existing code in extractFormants.py
It works locally, but fails if I try to create a pull request here on GitHub and somehow, it wants to add these code to the open pull request "Added badges to README". Is there a way to create another PR?

JoFrhwld added a commit that referenced this issue Oct 17, 2022
@JoFrhwld
Copy link
Owner Author

Closed with #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Easy to do and suitable for new developers refactor code refactoring
Projects
None yet
Development

No branches or pull requests

3 participants