Bug fixes for custom dictionaries #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
(cherry picked from commit 6bc72a4)
Update documentation for FAVE 2: * Include warning for old users on reading migration guide. * Write migration guide with FAQ * Simplify TOC code * Add index.rst for code and usage sections of docs * Add sphinx-project module into conf to make doc updates easier
This commit adds some testing for the cmudictionary.py module. In testing cmudictionary.CMU_Dictionary.add_dictionary_entries() a bug was uncovered in .check_transcription() which caused the output file to have more spaces than necessary. The cause was that function did not split the phone string when it was supposed to. This commit fixes the error and includes the test to prevent regression.
An error in cmudictionary.py caused add_dict to be overwritten and change type when a transcribed word was not in the cmu dictionary and had not yet been added to the output dictionary. This led to an obvious type error and a not obvious failure to add custom dictionaries. This commit fixes the issue by adding the given word as a key to add_dict and adds a test to prevent regressions. Resolves JoFrhwld#59
commit 6bc72a4 Author: Christian Brickhouse <brickhouse@stanford.edu> Date: Wed Aug 17 23:10:36 2022 -0700 Update deps, expand author info in toml commit 694ba50 Author: Christian Brickhouse <brickhouse@stanford.edu> Date: Wed Aug 17 23:09:34 2022 -0700 Bump version to 2.0.2-dev commit 716f95e Author: Christian Brickhouse <brickhouse@stanforf.edu> Date: Wed Aug 17 22:43:25 2022 -0700 Fix unintended overwrite of add_dict An error in cmudictionary.py caused add_dict to be overwritten and change type when a transcribed word was not in the cmu dictionary and had not yet been added to the output dictionary. This led to an obvious type error and a not obvious failure to add custom dictionaries. This commit fixes the issue by adding the given word as a key to add_dict and adds a test to prevent regressions. Resolves JoFrhwld#59 commit 40503a6 Author: Christian Brickhouse <brickhouse@stanforf.edu> Date: Wed Aug 17 22:31:34 2022 -0700 Add cmu_dict... test and fix write error This commit adds some testing for the cmudictionary.py module. In testing cmudictionary.CMU_Dictionary.add_dictionary_entries() a bug was uncovered in .check_transcription() which caused the output file to have more spaces than necessary. The cause was that function did not split the phone string when it was supposed to. This commit fixes the error and includes the test to prevent regression.
chrisbrickhouse
force-pushed
the
master
branch
from
52ec85a to
65fb4c2
Compare
|
Apologies for the force-push, only way to make the history sane on my main branch. Updated the description to account for hash changes and include the doc update |
chrisbrickhouse
changed the title
Closed
13 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmudictionary.pywhich resolves TypeError due to accidental overwrite of internal dictionary #59 and uncovered a previously unknown bug (now fixed; described in 6578a09 commit message).poetry.lockpyproject.tomlpartly to prep for future debian packaging