-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/parselmouth fix #85
Open
JoFrhwld
wants to merge
15
commits into
dev
Choose a base branch
from
feature/parselmouth-fix
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ed23a05
cherry pickk parselmouth initial working commit
JoFrhwld bee97a8
cherry-pick pulled praat call from aligner.py
JoFrhwld 7bf79e9
final parsemout refactor. closes #68
JoFrhwld a429f15
Merge dev into feature/parselmouth-fix
chrisbrickhouse 40082b0
Revert "Merge dev into feature/parselmouth-fix"
chrisbrickhouse 1dce53a
Merge dev into feature/parselmouth-fix
chrisbrickhouse 4a9612f
Restore praat scripts (#89)
chrisbrickhouse da154e8
Add deprecation for SoX and Praat methods.
chrisbrickhouse af8f871
Move parselmouth logic to new parselmouth_bridge
chrisbrickhouse 84b2c40
Restore removed test files
chrisbrickhouse 1d7ea80
moved over to pm bridge
JoFrhwld 90aa6e8
pm cross over debug
JoFrhwld b8ac214
Gotta do numpy checks rather than length
JoFrhwld 5cc21e0
trying to squash these bugs
JoFrhwld 8a27a3b
More np.nan bug fixes
JoFrhwld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,4 +11,5 @@ docs/_build | |
*.swp | ||
*.orig | ||
env | ||
dist/* | ||
dist/* | ||
.ipynb_checkpoints/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should turn this into a subclass of parselmouth.Formant instead of interfacing like this.
See https://stackoverflow.com/questions/15526858/how-to-extend-a-class-in-python for an example of how to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be rolled out into a separate module, like the
praat.Formant
andesps.Formant
modules are. I'd have to really think about how to make it a real subclass of parselmouth.Formant, since the formant class is written in C++.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm realizing that subclassing isn't going to work well given how the formant class comes to us---we don't create it, rather, it's returned from a function call. I started building a bridge in the most recent commits. See af8f871