Stream/episode 4 #27
Merged
Stream/episode 4 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FavoritesFragment was added to the activity but data is not being fetched/requested For #13
The SmsController correctly wraps all the functionality related to sms's. The current test showed that our favourites fragment is displayed the data correctly, ready to stop using mock data and wire up everything. Fix #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got DI with the SmsController
The SmsController correctly wraps all the functionality related to sms's. The current test
showed that our favorites fragment is displayed the data correctly, ready to stop using mock
data and wire up everything.
Fix #13