PKCE Feature is now on for AuthServer. #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered Oauth. Committing work in progress.
I previously mis-interpreted the TEFCA SOP for facilitated FHIR. I thought there were new metadata items to server from Discovery but it is actually new client metadata. The language is not explicit. I did not unwind all the work to make Metadata extensible. As this could be a requirement in the future. But for now I wanted to clean this up.
If the ServerSettings.RequirePkce is true then it will force all UDAP Clients to register with Client.RequirePkce set to true. But default the ServerSettings.RequirePkce is set to false. But if a client supplies the code_challenge then it will require a valid code_verifier.
Enable PKCE
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ServerSettings.RequirePkce is true then it will force all UDAP Clients to register with Client.RequirePkce set to true.
But default the ServerSettings.RequirePkce is set to false. But if a client supplies the code_challenge then it will require a valid code_verifier.