Fixup Udap.Model serialzation issues #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: tos was incorrectly set. Yes I know there isn't a test for this. There are so many test to still write for certifications and endorsements as there are a lot of rules.
Didn't make much progress. Kind of thinking about how I might work Certifications and Endorsements into this. Really, there is never been any love in this tool. Thinking about things like rules engines that may effect the roles given by auth servers or even how registering a Certification could effect a Authorization Extension object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the models to the place they will work with Udap.Auth.Server.Admin. Will have to revisit tests.
Just getting ready for connecta-a-thon Sept 2024.