-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn the multiplier on/off added. #295
Conversation
…tch-1 # Conflicts: # lib/combo-renderer.coffee
This reverts commit 83403a3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the multiplier in the checkLevel function
@@ -101,7 +102,7 @@ module.exports = | |||
@lastStreak = performance.now() | |||
@debouncedEndStreak() | |||
|
|||
n = n * (@level + 1) if n > 0 | |||
n = n * (@level + 1) if n > 0 and @conf['multiplier'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to check with this config on the checkLevel
function as well to avoid triggering the multiplier exclamations (those 2x, 3x).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lexcast
You need to check with this config on thecheckLevel
function as well to avoid triggering the multiplier
exclamations (those 2x, 3x).
Already fixed on commit
multiplier exclamation only if multiplier is enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commands added to context menu. #299
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, just the context menu needs the others commands.
menus/activate-power-mode.cson
Outdated
{ | ||
'label': 'Select Effects' | ||
'command': 'activate-power-mode:select-flow' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 2, one with the select-effect and another with the select-flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realise it, I'll fix it now.
}, | ||
{ | ||
'label': 'Reset Max Combo' | ||
'command': 'activate-power-mode:reset-max-combo' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add the disable and enable commands as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All commands added on ccaf0ad
Thank you @Jerajo |
To increase streak 1 by 1 or using the multiplier.