Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn the multiplier on/off added. #295

Merged
merged 12 commits into from
Aug 12, 2017
Merged

Turn the multiplier on/off added. #295

merged 12 commits into from
Aug 12, 2017

Conversation

Jerajo
Copy link
Contributor

@Jerajo Jerajo commented Aug 8, 2017

To increase streak 1 by 1 or using the multiplier.

@lexcast lexcast self-requested a review August 10, 2017 01:21
Copy link
Collaborator

@lexcast lexcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the multiplier in the checkLevel function

@@ -101,7 +102,7 @@ module.exports =
@lastStreak = performance.now()
@debouncedEndStreak()

n = n * (@level + 1) if n > 0
n = n * (@level + 1) if n > 0 and @conf['multiplier']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check with this config on the checkLevel function as well to avoid triggering the multiplier exclamations (those 2x, 3x).

Copy link
Contributor Author

@Jerajo Jerajo Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@Jerajo Jerajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexcast
You need to check with this config on the checkLevel function as well to avoid triggering the multiplier
exclamations (those 2x, 3x).

Already fixed on commit multiplier exclamation only if multiplier is enabled.

Copy link
Contributor Author

@Jerajo Jerajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commands added to context menu. #299

Copy link
Collaborator

@lexcast lexcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, just the context menu needs the others commands.

{
'label': 'Select Effects'
'command': 'activate-power-mode:select-flow'
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2, one with the select-effect and another with the select-flow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realise it, I'll fix it now.

},
{
'label': 'Reset Max Combo'
'command': 'activate-power-mode:reset-max-combo'
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add the disable and enable commands as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All commands added on ccaf0ad

image

@lexcast lexcast merged commit 251d361 into JoelBesada:master Aug 12, 2017
@lexcast
Copy link
Collaborator

lexcast commented Aug 12, 2017

Thank you @Jerajo

@Jerajo Jerajo deleted the patch-1 branch August 12, 2017 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants