Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error: jax_array config option is removed in jax v0.4.14 #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chaihahaha
Copy link

Reopened pull request, jax_array config option has been removed since jax commit 59509dc.

@JoeyTeng JoeyTeng added the enhancement New feature or request label Sep 18, 2023
@JoeyTeng
Copy link
Owner

Thank you for updating this! Just a quick reply, I would need a little bit of time to unblock the CI to merge it. I'll update you when I am done:)

@chaihahaha
Copy link
Author

@JoeyTeng Hello, I found a backward compatibility issue of the original modification and fixed it. Could you check this PR again?

@JoeyTeng
Copy link
Owner

JoeyTeng commented Nov 14, 2023

@chaihahaha sorry to let you wait for so long. I will check soon to fix the CI.
However, I see you are using dir(). It is not recommended to use that outside of interactive interpreter. Could you change that with hasattr()?
I don't have other issues with your PR. I just need to fix the CI in order to merge your PR.

@chaihahaha
Copy link
Author

Thanks for pointing it out, and thanks for your effort to maintain this repo.

I have fixed my RP with respect to your concern.

@chaihahaha
Copy link
Author

This pull request will close #18

@horizon-blue
Copy link

Hi hi, do we have any updates on this? The use of deprecated jax_array option is blocking the Colab example from running as well, and it would be great if this PR can be merged :)

@markusheimerl
Copy link

I can confirm, manually integrating the changes of this pull requests, makes the jaxrenderer functional again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants