Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in the workspace (mypy, black, python interpreter...) #70

Merged
merged 11 commits into from
Aug 28, 2023
Merged

Fix issues in the workspace (mypy, black, python interpreter...) #70

merged 11 commits into from
Aug 28, 2023

Conversation

JoffreyLGT
Copy link
Owner

@JoffreyLGT JoffreyLGT commented Aug 26, 2023 •
edited
Loading

  • Fix Python interpreter settings
  • Fix black-formatter extension
  • Add ignored folders to Pylance
  • Update workspace settings and extensions
  • Remove workspace settings from devcontainer
  • Fix mypy extension in backend project

Closes #67

@JoffreyLGT
Fix python interpreter settings in projects
43d845c
@JoffreyLGT
Fix black-formatter import and remove ruff config argument
d6a6b79
@JoffreyLGT
Add extra ignored folders for Pylance and format files
9871915
@JoffreyLGT
Fix issues with mypy in backend and update workspace
b86a5e8 
- Move most of the settings from devcontainer to workspace settings.
- Add recommended extensions into workspace for local environment users.
- Fix mypy issues in backend.

Note: datascience project is still not functional since it's just a copy of backend/datascience.
@JoffreyLGT JoffreyLGT added type: fix Fix an issue in the code type: chore Related tooling update and without production change scope: backend Related to backend project scope: global Related to all projects labels Aug 26, 2023
@JoffreyLGT JoffreyLGT temporarily deployed to development August 26, 2023 20:41 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 26, 2023 20:41 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT enabled auto-merge August 26, 2023 20:44
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 15:18 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 15:18 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:11 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:11 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:13 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:13 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:24 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 27, 2023 16:24 — with GitHub Actions Inactive
@JoffreyLGT
Fix hook deletion when in a git worktree
0af6247 
The previous code used a hard coded path to .git folder. Since worktrees have a reference to it, it was returning an error.
This fix make it work in all scenarios.
@JoffreyLGT JoffreyLGT temporarily deployed to development August 28, 2023 08:16 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 28, 2023 08:16 — with GitHub Actions Inactive
@JoffreyLGT
Copy link
Owner Author

Attention : il faut utiliser la préversion de l'extension VSCode Mypy.
Voir microsoft/vscode-python#20044

Landry-G01
Landry-G01 requested changes Aug 28, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@JoffreyLGT JoffreyLGT requested a review from Landry-G01 August 28, 2023 16:36
@JoffreyLGT JoffreyLGT temporarily deployed to development August 28, 2023 17:29 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT temporarily deployed to development August 28, 2023 17:29 — with GitHub Actions Inactive
@JoffreyLGT JoffreyLGT mentioned this pull request Aug 28, 2023
Merged
@JoffreyLGT JoffreyLGT merged commit f0f868f into main Aug 28, 2023
@JoffreyLGT JoffreyLGT deleted the JoffreyLGT/issue67 branch August 28, 2023 19:19
JoffreyLGT added a commit that referenced this pull request Aug 31, 2023
@JoffreyLGT
ci(github): add empty line for demo purpose
1bae0b8 
It doesn't do anything special, I am just testing the feature

#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Landry-G01 Landry-G01 Landry-G01 approved these changes

@GuetchArnaud GuetchArnaud Awaiting requested review from GuetchArnaud

Assignees
No one assigned
Labels
scope: backend Related to backend project scope: global Related to all projects type: chore Related tooling update and without production change type: fix Fix an issue in the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Corriger les soucis d'environnement dans le projet
2 participants
@JoffreyLGT @Landry-G01