Skip to content

Commit

Permalink
Merge branch 'master' into customMessages-from-external-mf-does-not-work
Browse files Browse the repository at this point in the history 
* master:
  fix fd-modal mix-up (SAP#1068)
  who is using luigi in about page (SAP#1077)
  • Loading branch information
@JohannesDoberer
JohannesDoberer committed Feb 3, 2020
2 parents 99601f7 + 5469bcc commit 48a5a62
Show file tree
Hide file tree
Showing 3 changed files with 91 additions and 85 deletions.
22 changes: 9 additions & 13 deletions core/src/Modal.html
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<svelte:window on:keydown="{handleKeydown}"/>
<div class="fd-ui__overlay fd-overlay fd-overlay--modal" style="z-index:999">
<div class="fd-modal" data-testid="modal-mf">
<div class="fd-modal lui-modal-mf" data-testid="modal-mf">
<div class="fd-modal__content" style="height:100%">
<div class="fd-modal__header">
{#if modalSettings.title}
Expand Down Expand Up @@ -37,7 +37,7 @@ <h1 class="fd-modal__title">{modalSettings.title}</h1>
let pathData;
let nodeParams;

const prepareNodeData = async (path) => {
const prepareNodeData = async path => {
const pathUrlRaw =
path && path.length ? GenericHelpers.getPathWithoutHash(path) : '';
const params = RoutingHelpers.parseParams(pathUrlRaw.split('?')[1]);
Expand All @@ -52,16 +52,13 @@ <h1 class="fd-modal__title">{modalSettings.title}</h1>
isDataPrepared = true;
};

const getNode = async (path) => {
const getNode = async path => {
if (isDataPrepared) {
const iframe = createIframeModal(
nodeObject.viewUrl,
{
context: pathData.context,
pathParams: pathData.pathParams,
nodeParams
}
);
const iframe = createIframeModal(nodeObject.viewUrl, {
context: pathData.context,
pathParams: pathData.pathParams,
nodeParams
});
dispatch('iframeCreated', {
modalIframe: iframe,
modalIframeData: { ...pathData, nodeParams }
Expand All @@ -71,7 +68,7 @@ <h1 class="fd-modal__title">{modalSettings.title}</h1>
}
};
const createIframeModal = (viewUrl, componentData) => {
const elem = document.getElementsByClassName('fd-modal');
const elem = document.getElementsByClassName('lui-modal-mf');
let modalSize = '80%';
if (modalSettings.size) {
if (modalSettings.size === 'l') {
Expand Down Expand Up @@ -100,7 +97,6 @@ <h1 class="fd-modal__title">{modalSettings.title}</h1>
return iframe;
};


// [svelte-upgrade warning]
// beforeUpdate and afterUpdate handlers behave
// differently to their v2 counterparts
Expand Down
62 changes: 25 additions & 37 deletions website/landingpage/dev/src/pages/about.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,33 @@
</div>
<div class="row">
<div class="columns xlarge-9 content-wrapper" id="stickyAnchor" data-something>
<p>Offering a wide array of products, many companies are also offering just as many entry points as user interfaces. Oftentimes, these entry points and user interfaces lack in consistency and recognizability. Seamless transition between products is often hard to achieve, and this is one of the cornerstones of a great customer experience. Ensuring a consistent look and feel and harmonizing all the products and applications is a demanding and expensive task. It means rebuilding them from the ground up and fulfilling particular UX requirements. One of the reasons why it is so difficult is that different products are developed on different technology stacks.</p>
<p>Offering a wide array of products, many companies are also offering just as many entry points as user
interfaces. Oftentimes, these entry points and user interfaces lack in consistency and recognizability. Seamless
transition between products is often hard to achieve, and this is one of the cornerstones of a great customer
experience. Ensuring a consistent look and feel and harmonizing all the products and applications is a demanding
and expensive task. It means rebuilding them from the ground up and fulfilling particular UX requirements. One
of the reasons why it is so difficult is that different products are developed on different technology stacks.
</p>

<p>We aspire to sell our customers a great customer experience and we believe that a great customer experience should be available to both customers and the people who make this customer experience possible – administrators and developers.</p>
<p>We aspire to sell our customers a great customer experience and we believe that a great customer experience
should be available to both customers and the people who make this customer experience possible – administrators
and developers.</p>

<p>With this goal in mind, we have designed Luigi, which makes it possible to transform your product smoothly from a monolith to a micro-service and micro-frontend architecture. With Luigi, you build an overarching administration and business user application and re-use the functions and views of the applications currently available. Also, you can take modules or even entire applications from third-party vendors and integrate them directly into your application.</p>
<p>With this goal in mind, we have designed Luigi, which makes it possible to transform your product smoothly from
a monolith to a micro-service and micro-frontend architecture. With Luigi, you build an overarching
administration and business user application and re-use the functions and views of the applications currently
available. Also, you can take modules or even entire applications from third-party vendors and integrate them
directly into your application.</p>

<p>Luigi is your choice if you are using independent distributed UI teams to develop, deploy, maintain, and operate modules and end-to-end features independently. Such distributed teams do not have to make commitments to the same repository and depend on each other during the development and release cycles. This way, there is no need for any specific team to be the domain expert and fully own the entire underlying feature set and product portfolio behind the monolith UI. Another advantage is that, once developed, these independently developed features can be used by multiple solutions.</p>
<p>Luigi is your choice if you are using independent distributed UI teams to develop, deploy, maintain, and
operate modules and end-to-end features independently. Such distributed teams do not have to make commitments to
the same repository and depend on each other during the development and release cycles. This way, there is no
need for any specific team to be the domain expert and fully own the entire underlying feature set and product
portfolio behind the monolith UI. Another advantage is that, once developed, these independently developed
features can be used by multiple solutions.</p>

<p>Finally, Luigi provides out-of-the-box features such as a shell bar, a navigation component, and easy-to-use functions to display alerts, confirmation messages, etc.</p>
<p>Finally, Luigi provides out-of-the-box features such as a shell bar, a navigation component, and easy-to-use
functions to display alerts, confirmation messages, etc.</p>
</div>
<div class="columns xlarge-3 right show-for-xlarge" data-sticky-container>
<div class="sticky" data-sticky data-margin-top="6" data-anchor="stickyAnchor">
Expand All @@ -42,37 +60,7 @@ <h2 class="title-2 has-big-margin">From startups to the largest companies</h2>
</div>
<div class="row">
<div class="column small-12">
<ul class="clients-list">
<li class="item">
<a href="https://www.sap.com/index.html" target="_blank"
><img src="{{root}}assets/img/logos/sap.svg" alt="SAP"
/></a>
</li>
<li class="item">
<a href="https://kyma-project.io/" target="_blank"
><img src="{{root}}assets/img/logos/kyma.svg" alt="Kyma"
/></a>
</li>
<li class="item">
<a href="https://www.saas-ag.com/" target="_blank"
><img
src="{{root}}assets/img/logos/saas.svg"
alt="SAAS - Software as a Service"
/></a>
</li>
<li class="item">
<a href="https://citizen-e.io/" target="_blank"
><img
src="{{root}}assets/img/logos/sensation.svg"
alt="Citizen-e.io"
/></a>
</li>
<li class="item">
<a href="https://www.snk.de/" target="_blank"
><img src="{{root}}assets/img/logos/snk.svg" alt="SNK"
/></a>
</li>
</ul>
{{> whoisusingluigi}}
</div>
</div>
</section>
Expand All @@ -86,4 +74,4 @@ <h2 class="title-2 has-big-margin">From startups to the largest companies</h2>
<a class="btn-primary" href="https://docs.luigi-project.io/docs/application-setup.md">GET STARTED</a>
</div>
</div>
</section>
</section>
92 changes: 57 additions & 35 deletions website/landingpage/public/about.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,33 @@
</div>
<div class="row">
<div class="columns xlarge-9 content-wrapper" id="stickyAnchor" data-something>
<p>Offering a wide array of products, many companies are also offering just as many entry points as user interfaces. Oftentimes, these entry points and user interfaces lack in consistency and recognizability. Seamless transition between products is often hard to achieve, and this is one of the cornerstones of a great customer experience. Ensuring a consistent look and feel and harmonizing all the products and applications is a demanding and expensive task. It means rebuilding them from the ground up and fulfilling particular UX requirements. One of the reasons why it is so difficult is that different products are developed on different technology stacks.</p>
<p>Offering a wide array of products, many companies are also offering just as many entry points as user
interfaces. Oftentimes, these entry points and user interfaces lack in consistency and recognizability. Seamless
transition between products is often hard to achieve, and this is one of the cornerstones of a great customer
experience. Ensuring a consistent look and feel and harmonizing all the products and applications is a demanding
and expensive task. It means rebuilding them from the ground up and fulfilling particular UX requirements. One
of the reasons why it is so difficult is that different products are developed on different technology stacks.
</p>

<p>We aspire to sell our customers a great customer experience and we believe that a great customer experience should be available to both customers and the people who make this customer experience possible – administrators and developers.</p>
<p>We aspire to sell our customers a great customer experience and we believe that a great customer experience
should be available to both customers and the people who make this customer experience possible – administrators
and developers.</p>

<p>With this goal in mind, we have designed Luigi, which makes it possible to transform your product smoothly from a monolith to a micro-service and micro-frontend architecture. With Luigi, you build an overarching administration and business user application and re-use the functions and views of the applications currently available. Also, you can take modules or even entire applications from third-party vendors and integrate them directly into your application.</p>
<p>With this goal in mind, we have designed Luigi, which makes it possible to transform your product smoothly from
a monolith to a micro-service and micro-frontend architecture. With Luigi, you build an overarching
administration and business user application and re-use the functions and views of the applications currently
available. Also, you can take modules or even entire applications from third-party vendors and integrate them
directly into your application.</p>

<p>Luigi is your choice if you are using independent distributed UI teams to develop, deploy, maintain, and operate modules and end-to-end features independently. Such distributed teams do not have to make commitments to the same repository and depend on each other during the development and release cycles. This way, there is no need for any specific team to be the domain expert and fully own the entire underlying feature set and product portfolio behind the monolith UI. Another advantage is that, once developed, these independently developed features can be used by multiple solutions.</p>
<p>Luigi is your choice if you are using independent distributed UI teams to develop, deploy, maintain, and
operate modules and end-to-end features independently. Such distributed teams do not have to make commitments to
the same repository and depend on each other during the development and release cycles. This way, there is no
need for any specific team to be the domain expert and fully own the entire underlying feature set and product
portfolio behind the monolith UI. Another advantage is that, once developed, these independently developed
features can be used by multiple solutions.</p>

<p>Finally, Luigi provides out-of-the-box features such as a shell bar, a navigation component, and easy-to-use functions to display alerts, confirmation messages, etc.</p>
<p>Finally, Luigi provides out-of-the-box features such as a shell bar, a navigation component, and easy-to-use
functions to display alerts, confirmation messages, etc.</p>
</div>
<div class="columns xlarge-3 right show-for-xlarge" data-sticky-container>
<div class="sticky" data-sticky data-margin-top="6" data-anchor="stickyAnchor">
Expand All @@ -115,36 +133,41 @@ <h2 class="title-2 has-big-margin">From startups to the largest companies</h2>
</div>
<div class="row">
<div class="column small-12">
<!--
Instructions for adding new logos:
* Fork this repo, and clone your fork
* Create a branch called e.g. `add-myorganisation-logo`
* Add the logo to the `dev/src/assets/img/logos` directory (preferably SVG)
* Add a new <li> tag in this component.
* Create a pull request. Thanks!
-->
<ul class="clients-list">
<li class="item">
<a href="https://www.sap.com/index.html" target="_blank"
><img src="assets/img/logos/sap.svg" alt="SAP"
/></a>
</li>
<li class="item">
<a href="https://kyma-project.io/" target="_blank"
><img src="assets/img/logos/kyma.svg" alt="Kyma"
/></a>
</li>
<li class="item">
<a href="https://www.saas-ag.com/" target="_blank"
><img
src="assets/img/logos/saas.svg"
alt="SAAS - Software as a Service"
/></a>
</li>
<li class="item">
<a href="https://citizen-e.io/" target="_blank"
><img
src="assets/img/logos/sensation.svg"
alt="Citizen-e.io"
/></a>
</li>
<li class="item">
<a href="https://www.snk.de/" target="_blank"
><img src="assets/img/logos/snk.svg" alt="SNK"
/></a>
</li>
<li class="item">
<a href="https://www.sap.com/index.html" target="_blank"><img src="assets/img/logos/sap.svg"
alt="SAP" /></a>
</li>
<li class="item">
<a href="https://kyma-project.io/" target="_blank"><img src="assets/img/logos/kyma.svg"
alt="Kyma" /></a>
</li>
<li class="item">
<a href="https://www.saas-ag.com/" target="_blank"><img src="assets/img/logos/saas.svg"
alt="SAAS - Software as a Service" /></a>
</li>
<li class="item">
<a href="https://citizen-e.io/" target="_blank"><img src="assets/img/logos/sensation.svg"
alt="Citizen-e.io" /></a>
</li>
<li class="item">
<a href="https://www.snk.de/" target="_blank"><img src="assets/img/logos/snk.svg" alt="SNK" /></a>
</li>
<li class="item">
<a href="http://www.cobrick.com" target="_blank"><img src="assets/img/logos/cobrick.svg" alt="co.brick" /></a>
</li>
<li class="item">
<a href="https://github.com/SAP/luigi/blob/master/website/landingpage/dev/src/partials/whoisusingluigi.html"
class="btn-secondary" target="_blank">+ your company</a>
</li>
</ul>
</div>
</div>
Expand All @@ -160,7 +183,6 @@ <h2 class="title-2 has-big-margin">From startups to the largest companies</h2>
</div>
</div>
</section>

</div>

<footer class="p-footer ">
Expand Down

0 comments on commit 48a5a62

Please sign in to comment.