Add support for youtube-nocookie.com domain in YoutubeEmbed plugin #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 4 4
Lines 971 971
=======================================
Hits 943 943
Misses 19 19
Partials 9 9 ☔ View full report in Codecov by Sentry. |
|
@devAbreu thanks a lot for submitting the PR! This sounds like a good improvement 👍 Just one thing: Please remove the logging for now. (Logging should be customizable, maybe only when a debug mode is activated. Or when a logger is passed in. Since we don't have that yet, I would leave this out for now...) |
|
@JohannesKaufmann Great. Thank you for the suggestion. 👍🏿 |
JohannesKaufmann
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for handling YouTube iframes using the
youtube-nocookie.comdomain in theYoutubeEmbedplugin.Changes Made
iframe_youtube.goto includeyoutube-nocookie.com.Justification
youtube-nocookie.comis a variant of YouTube that is used to enhance user privacy by not storing cookies. These changes will allow the plugin to correctly handle these iframes.Thank you for considering this improvement.