Fix infinite loop #945
Merged
Fix infinite loop #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JohannesKlauss
requested changes
Feb 18, 2023
src/useHotkeys.ts
Outdated
| @@ -143,7 +143,7 @@ export default function useHotkeys<T extends HTMLElement>( | |||
| parseKeysHookInput(keys, memoisedOptions?.splitKey).forEach((key) => proxy.removeHotkey(parseHotkey(key, memoisedOptions?.combinationKey))) | |||
| } | |||
| } | |||
| }, [keys, memoisedOptions, enabledScopes]) | |||
| }, [JSON.stringify(keys), memoisedOptions, enabledScopes]) | |||
There was a problem hiding this comment.
Hmh... I don't really want to use JSON.stringify here. It's an expensive operation and you shouldn't hack the dependency array that way. A better approach in my opinion would be to make sure we are always dealing with a string:
const _keys = keys instanceof Array ? keys.join(_options?.splitKey) : keysThen we can reference the _keys everywhere we use keys and also the check in parseKeysHookInput could be removed.
|
Thanks @JohannesKlauss I'm trying to prioritize some time to make these changes. |
|
@JohannesKlauss sorry for the delay but I've updated the PR per your comment. Let me know if that works out alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#944
This fixes an infinite loop that is caused by an array dependency in a
useEffect. I simply serialize the array dependency in question only because using a ref or memoizing thekeysprop was causing a test failure intests/useHotkeys.test.tsx L#274.