Feat: Expose descriptions for currently-bound hotkeys. #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zenzen-sol
changed the title
|
Please add a test that tests the behavior, other than that it looks good! |
|
I was about to embed the library into our project and I must say, that this feature of providing description would be really helpful for our case. Looking forward to this MR to be merged. 🙏 |
|
Sure. I'll add a test ASAP. |
JohannesKlauss
requested changes
Mar 19, 2023
JohannesKlauss
approved these changes
Mar 24, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
descriptionoption in thehotkeysarray returned byuseHotkeysContext(). Helpful if you want to display a list of currently-active hotkeys to the user.