Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update rate option to settings #23

Closed
haywirephoenix opened this issue Feb 16, 2024 · 1 comment · Fixed by #24
Closed

Add update rate option to settings #23

haywirephoenix opened this issue Feb 16, 2024 · 1 comment · Fixed by #24

Comments

@haywirephoenix
Copy link
Contributor

SceneHook causes my debug capsules in scene view to draw erratically when it invokes the LateUpdateEvent. Same result when using the TMP UI. Commenting out the event in lateupdate and adding the below fixes the problem.

 private void FixedUpdate()
        {
            LateUpdateEvent?.Invoke(Time.fixedDeltaTime);
        }

Adding an update rate option to the settings will allow people to select what rate works for them. Excellent work with this asset.

@haywirephoenix
Copy link
Contributor Author

To replicate, use the (free) Physics Debug Extension by RotaryHeart and draw a debug CapsuleCast during FixedUpdate on a moving object while runtime-monitoring is displaying using the [Monitor] attribute.

Physics.CapsuleCast(capsuleBottom, capsuleTop, capsuleRadius, direction, out RaycastHit hit, maxDistance, GroundLayers.value, PreviewCondition.Editor, 0f, Color.blue, Color.white, false, CastDrawType.Minimal);

At it's core it only uses Debug.Draw when drawing in the editor so it can be an issue outside of this asset also.

JohnBaracuda added a commit that referenced this issue Apr 6, 2024
Add UpdateRate settings, Include in SceneHook - fixes #23
JohnBaracuda added a commit that referenced this issue Apr 6, 2024
- Added IMonitorHandle.GetValueAsObject() to get a monitored object without any formattig. As requrest in #26
- Fixed #23 Users can select the update rate of SceneHook in the Settings to Update, FixedUpdate, or LateUpdate
Fixed #22 Grouped monitored objctes are now unregistered correctly (TextMeshPro)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant