Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added_yes_no_question #70

Merged
merged 3 commits into from
Aug 22, 2023
Merged

added_yes_no_question #70

merged 3 commits into from
Aug 22, 2023

Conversation

munoztd0
Copy link
Collaborator

Added yes or no questions for client danger errors to be able to bypass them in local tests

@JohnCoene
Copy link
Owner

We should remove the browser calls.

Does askYesNo only work interactively (I.e.: interactive())?

@munoztd0
Copy link
Collaborator Author

We should remove the browser calls.

Does askYesNo only work interactively (I.e.: interactive())?

Yes you are right! Whatabout menu() ?

@munoztd0 munoztd0 reopened this Aug 16, 2023
@JohnCoene
Copy link
Owner

I generally just use readline but if what you have works, no need to change, I would just wrap that in if(interactive())

Although, as I write that, I'm not sure how that would work because technically a shiny server is never interactive()?

Hmmm

@munoztd0
Copy link
Collaborator Author

So yeah I changed it to menu() so it can actually work not interactively.. Does that work for you ?

@JohnCoene
Copy link
Owner

Using menu() within a shiny application throws an error on my end (not usable outside of an interactive environment). I might be missing something.

@munoztd0
Copy link
Collaborator Author

Using menu() within a shiny application throws an error on my end (not usable outside of an interactive environment). I might be missing something.

Wrapped it in if(inteactive){} statements

@JohnCoene
Copy link
Owner

Thanks I'll test (I think this will never be true within Shiny)

@munoztd0
Copy link
Collaborator Author

Thanks I'll test (I think this will never be true within Shiny)

Yeah but at least you can test your app by running the code snippet such as in #64

@munoztd0 munoztd0 merged commit 6154e98 into master Aug 22, 2023
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants