Include fileEnding in Import handler for plugins #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, invoking a non existing API method would return an HTTP/200
response with a JSON payload {"code":3,"message":"no such function"}.
This commit changes the HTTP status code to 404, leaving the payload as-is.
Before:
curl --verbose "http://localhost:9001/api/1/notExisting?apikey=ABCDEF"
< HTTP/1.1 200 OK
< X-Powered-By: Express
[...]
{"code":3,"message":"no such function","data":null}
After:
curl --verbose "http://localhost:9001/api/1/notExisting?apikey=ABCDEF"
< HTTP/1.1 404 OK
< X-Powered-By: Express
[...]
{"code":3,"message":"no such function","data":null}
Fixes #3546.
…an extra list item
…toolbar scrollable Before this change there was always a single toolbar on the top, with both Colibris and the legacy skin. When the screen size was reduced: - the legacy skin would compact the icons in the toolbar (this was fine, indeed); - Colibris would hide some formatting icons. This would hamper the functionality for mobile users. After this change both the skins work in the same way, which is the following: - when the screen gets smaller the right toolbar (the one with "export", "timeslider", and other buttons) goes to the bottom of the screen; - when there are many icons, the toolbar keeps all of them, and to see them the user must drag the toolbar. This behaviour will probably be changed before release, opting instead to show a "+" button when there is an overflow, since this appears to be more discoverable (see the discusison in #3697). Do not tested with custom toolbar elements (toolbar.left and toolbar.right configuration items in settings.json). Fixes #3697.
… allowUnknownFileEnds is true By specification, when settings.allowUnknownFileEnds is true and the user tries to import a file with an unknown extension (this includes no extension), Etherpad tries to import it as txt. This broke in Etherpad 1.8.0, that abruptly terminates the processing with an UnhandledPromiseRejectionWarning. This patch restores the intended behaviour, and allows to import as text a file with an unknown extension (on no extension). In order to catch the UnhandledPromiseRejectionWarning we had to use fsp_rename(), which is declared earlier in the code and is promised based instead of fs.rename(), which is callback based. Fixes #3710.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.