Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of lists appearing immediately after a paragraph #63

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

adam-fowler
Copy link
Contributor

If no space is left between formatted text and a list then the list isn't processed as a list

This is a test
- One
- Two

Became <p>This is a test - One - Two</p>.
This fix ensures the list is rendered correctly as <p>This is a test</p><ul><li>One</li><li>Two</li></ul>.

It is a very simple fix to check for "-" character after a new line along with other special characters.

@kevinrenskers
Copy link

Running into the same problem. Can we get this merged in?

Copy link
Owner

@JohnSundell JohnSundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this fix @adam-fowler, and I'm so sorry for taking so ridiculously long to review this PR!

@JohnSundell JohnSundell merged commit 929b428 into JohnSundell:master Apr 7, 2023
@adam-fowler adam-fowler deleted the list-after-paragraph branch April 7, 2023 15:09
@adam-fowler
Copy link
Contributor Author

My god, I'd given up on these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants