Finishing Touches #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
JohnTheCoolingFan
requested changes
Feb 2, 2024
|
Marked another place where CI errors |
|
Made those fixes and finally got the circular arc test right. Ready for merge and final reviews? |
JohnTheCoolingFan
approved these changes
Feb 3, 2024
JohnTheCoolingFan
approved these changes
Feb 3, 2024
JohnTheCoolingFan
requested changes
Feb 3, 2024
JohnTheCoolingFan
approved these changes
Feb 3, 2024
JohnTheCoolingFan
requested changes
Feb 3, 2024
JohnTheCoolingFan
approved these changes
Feb 3, 2024
JohnTheCoolingFan
merged commit 1280053
into
JohnTheCoolingFan:cubic-splines-overhaul
22 checks passed
JohnTheCoolingFan
pushed a commit
that referenced
this pull request
Sep 6, 2024
…3906) # Objective - Second part of bevyengine#13900 - based on bevyengine#13905 ## Solution - check_dir_light_mesh_visibility defers setting the entity's `ViewVisibility `so that Bevy can schedule it to run in parallel with `check_point_light_mesh_visibility`. - Reduce HashMap lookups for directional light checking as much as possible - Use `par_iter `to parallelize the checking process within each system. --------- Co-authored-by: Kristoffer Søholm <k.soeholm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[0, N]whereNis the number of curves. This makes both nurbs and b-splines have the same parametric domain.RationalSegementnow tracks the size of it's parametric domain, as derived from the knot vector.RationalCurvenow allows for different sizes of segment, and clamps the parameter to the curve domain. The output ofRationalCurve::segmentis mapped to[0, 1].