Skip to content

Commit

Permalink
Add FIXME note about storing &'tcx str
Browse files Browse the repository at this point in the history
  • Loading branch information
jumbatm committed Jan 11, 2021
1 parent 7a46a4f commit 4b740ac
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions compiler/rustc_lint/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2596,6 +2596,11 @@ declare_lint! {
}

pub struct ClashingExternDeclarations {
/// Map of function symbol name to the first-seen hir id for that symbol name.. If seen_decls
/// contains an entry for key K, it means a symbol with name K has been seen by this lint and
/// the symbol should be reported as a clashing declaration.
// FIXME: Technically, we could just store a &'tcx str here without issue; however, the
// `impl_lint_pass` macro doesn't currently support lints parametric over a lifetime.
seen_decls: FxHashMap<String, HirId>,
}

Expand Down

0 comments on commit 4b740ac

Please sign in to comment.