Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Content Datatype types #817

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add Content Datatype types #817

merged 1 commit into from
Nov 8, 2024

Conversation

Barocena
Copy link
Contributor

@Barocena Barocena commented Nov 8, 2024

this PR adds types for Content Datatype

JohnnyMorganz
JohnnyMorganz approved these changes Nov 8, 2024
View reviewed changes
Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We should probably move away from this JSON file sometime soon since there's no reason for the indirection anymore, maybe we can directly writes these in the Python script

@JohnnyMorganz JohnnyMorganz merged commit e199744 into JohnnyMorganz:main Nov 8, 2024
11 checks passed
@ddavness ddavness mentioned this pull request Dec 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyMorganz JohnnyMorganz JohnnyMorganz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barocena @JohnnyMorganz