Add server path configuration option to the VSCode extension #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: I've tested this and it works great! |
JohnnyMorganz
requested changes
Jan 12, 2025
|
Marking this as a draft until I clean up the nixos files |
|
Accidentally did a merge, so I'm gonna condense my changes into a single commit and force push |
cswimr
force-pushed
the
add-server-path-configuration-option
branch
from
1a8ba5f to
f1e7a8d
Compare
JohnnyMorganz
approved these changes
Feb 1, 2025
No problem, and yeah, I'll commit that real quick. Thanks for the review! |
|
oops that merged, sigh |
cswimr
force-pushed
the
add-server-path-configuration-option
branch
from
1a9559a to
0c163f0
Compare
cswimr
force-pushed
the
add-server-path-configuration-option
branch
from
0c163f0 to
b47da29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a configuration value (
luau-lsp.serverPath) to the VSCode extension that lets you change the path of the Luau LSP server binary. This is useful for platforms like NixOS, where the included binary doesn't work by default. This hasn't been tested yet.