Removes test_full_coinjoin #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
approved these changes
Apr 9, 2022
The former was a stale test that we never got to a properly working state, so we replace it with test/e2e-coinjoin-test.py which does the same job more effectively, using the RPC-API. Also removed the old file from parameters of run_tests script.
AdamISZ
force-pushed
the
remove-test-full-coinjoin
branch
from
eea4cbc to
3b3bd39
Compare
|
As per discussion in #1229, added in also the newer equivalent, This looks like it bumps up total test time by about 40 seconds. The edits were actually related: while this test was run isolated, I could override default fidelity bond time values to cut down wallet load time but that borked other tests (because the changes were global); changed to use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stale test that we never got to a properly
working state, but we now have test/e2e-coinjoin-test.py
which does the same job more effectively, using the RPC-API.
Also removed this from parameters of run_tests script.