Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mixdepth filtering for showutxos #1633

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

kristapsk
Copy link
Member

Resolves #1539. As usual, also added type hints here and there.

@kristapsk
Copy link
Member Author

There is no test coverage, opened separate issue about that - #1634.

@theborakompanioni Would filtering by mixdepth be useful for Jam and should be added to RPC API too?

@theborakompanioni
Copy link
Contributor

@theborakompanioni Would filtering by mixdepth be useful for Jam and should be added to RPC API too?

Hey @kristapsk. Thanks for having Jam in the back of your mind 🧡
I do not think it is really necessary for Jam to filter by mixdepth as I see no real advantage fetching UTXOs for n mixdepths separately than filtering it on the client side directly. 🙏

@kristapsk
Copy link
Member Author

Seems that nobody wants to review this. It's relatively simple change, affects only wallet-tool.py showutxos. Merging.

@kristapsk kristapsk merged commit 5bfa08c into JoinMarket-Org:master Feb 23, 2024
8 checks passed
@kristapsk kristapsk deleted the showutxos-mixdepth branch February 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet-tool.py showutxos ignores -m (mixdepth) argument
2 participants