Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

ob-watcher hangs from bad maker data #179

Closed
CohibAA opened this issue Aug 9, 2015 · 1 comment
Closed

ob-watcher hangs from bad maker data #179

CohibAA opened this issue Aug 9, 2015 · 1 comment

Comments

@CohibAA
Copy link
Contributor

CohibAA commented Aug 9, 2015

It is trivial to hang the ob-watcher.py script using a malicious or poorly coded maker bot, preventing the orderbook.html page from displaying until the bad order information is no longer showing on the !orderbook data. Similar to #178, probably another quick fix on ob-watcher.py exception handling will prevent this.
adlai added a commit to adlai/joinmarket that referenced this issue Aug 9, 2015
@adlai
validate cjfee in OrderbookWatch.on_order_seen
9f5e3d6 
resolves JoinMarket-Org#178 and JoinMarket-Org#179
@adlai adlai mentioned this issue Aug 9, 2015
Merged
@CohibAA
Copy link
Contributor Author

CohibAA commented Aug 9, 2015

closing, fixed by #180

@CohibAA CohibAA closed this as completed Aug 9, 2015
ghtdak pushed a commit to ghtdak/joinmarket that referenced this issue Oct 1, 2015
@adlai
validate cjfee in OrderbookWatch.on_order_seen [yapf]
a024934 
resolves JoinMarket-Org#178 and JoinMarket-Org#179
ghtdak pushed a commit to ghtdak/joinmarket that referenced this issue Oct 4, 2015
@adlai
validate cjfee in OrderbookWatch.on_order_seen
a8b7461 
resolves JoinMarket-Org#178 and JoinMarket-Org#179
ghtdak pushed a commit to ghtdak/joinmarket that referenced this issue Dec 4, 2015
@adlai
validate cjfee in OrderbookWatch.on_order_seen
a0bb3fe 
resolves JoinMarket-Org#178 and JoinMarket-Org#179

[gitreformat yapf-ify (github/ghtdak) on Fri Dec  4 04:50:39 2015]
[from commit: 9f5e3d6]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CohibAA