Changed appearance and sortablility of table and website #115
Conversation
- Converted whole site to bootstrap
- Added "GitHub" and "Getting Started" links in the menubar
- Included "sortable.js" for sorting the table, client side
- Removed server-side table sorting
|
Looks great. |
|
Thanks! Can you merge it into your master, after your review of course. You may want to change the background color to white, although it's up to you. |
|
I don't have much of an opinion right now of the color scheme, or anything gui user-facing. Will merge soon. |
|
Could you just accept the pull request then! With that, I'll contact the owner of JoinMarket.io and get that updated. |
| ul li a { | ||
| padding 0.2em 1em; | ||
| } | ||
| </style>--> |
There was a problem hiding this comment.
Can you remove these commented out styles?
|
They can be removed when the pull request is accepted. |
|
I would prefer the commented out parts be removed before merging. I usually leave PRs open for a while so others can comment. |
|
I have removed the commented out parts, it is added to this pull request! |
|
You seem quite eager to contribute code, have you seen this wiki page about small projects I think are good https://github.com/chris-belcher/joinmarket/wiki/What-can-I-do-for-JoinMarket%3F |
Changed appearance and sortablility of table and website
|
I have, I'll work on one or two today actually! Thanks |
Changed appearance and sortablility of table and website
Changed appearance and sortablility of table and website
Changed appearance and sortablility of table and website [gitreformat yapf-ify (github/ghtdak) on Fri Dec 4 04:49:29 2015] [from commit: 44ce8ce]
- Removed server-side table sorting
I hope you accept this pull request because it adds a user front-end to view the inner workings of this project, and it's way more presentable.