This repository has been archived by the owner on May 13, 2022. It is now read-only.
Fix BitcoinCoreWallet's UTXO selection. #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UTXO selection of BitcoinCoreWallet with fromaccount set did accept also UTXO's without an account. This is in direct contradiction to the user's wish for a specific account. With this patch, we really only accept UTXO's that have the specified account set explicitly.
|
Good fix. |
|
I have a hard time following what is being checked for. Is it an idea to extract the right hand side of the if statement into a predicate method? if self.fromaccount and isSomeSaneName(u):
continue
... |
|
This code is meant to allow the user to choose which bitcoin core account to spend from, see https://bitcoin.org/en/developer-reference#listunspent |
chris-belcher
added a commit
that referenced
this pull request
Jul 4, 2015
Fix BitcoinCoreWallet's UTXO selection.
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 1, 2015
…om [yapf] Fix BitcoinCoreWallet's UTXO selection.
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 4, 2015
Fix BitcoinCoreWallet's UTXO selection.
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Dec 4, 2015
Fix BitcoinCoreWallet's UTXO selection. [gitreformat yapf-ify (github/ghtdak) on Fri Dec 4 04:49:33 2015] [from commit: 764768e]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UTXO selection of BitcoinCoreWallet with fromaccount set did accept also UTXO's without an account. This is in direct contradiction to the user's wish for a specific account. With this patch, we really only accept UTXO's that have the specified account set explicitly.