This repository has been archived by the owner on May 13, 2022. It is now read-only.
use curl instead of wget for maximal portability #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed. |
|
Agree, untested acknowledge That commit code probably isnt portable to windows which doesnt have /dev/null edit: although looks like the -s options will mean the -o /dev/null is unnecessary. |
|
-s silences the progress updates, but curl still outputs the headers (from -I) to stdout. If portability trumps spam, we could leave them, and let each person customize complete silencing for their platform if necessary. I've also added the same timeout as the wget code. |
|
curl: option --connect-timeout: expected a proper numerical parameter Instead, |
|
Seems to work well when timeout changed to an integer. |
chris-belcher
added a commit
that referenced
this pull request
Jul 18, 2015
use curl instead of wget for maximal portability
|
edited the wiki to change wget to curl |
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 1, 2015
use curl instead of wget for maximal portability
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 4, 2015
use curl instead of wget for maximal portability
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Dec 4, 2015
use curl instead of wget for maximal portability [gitreformat yapf-ify (github/ghtdak) on Fri Dec 4 04:50:05 2015] [from commit: b994e10]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see http://daniel.haxx.se/docs/curl-vs-wget.html for details