Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Add travis for testing, testing files in test directory #163

Merged
merged 3 commits into from
Jul 30, 2015

Conversation

AdamISZ
Copy link
Member

@AdamISZ AdamISZ commented Jul 25, 2015

Details:

  • Test subdirectory created, with supporting files for regression tests:
  • regtest_joinmarket.cfg - special config for regtest running, bitcoin.conf - for same, regtest.py same as previous but modified and put under /test
  • Travis automated build test support: added .travis.yml to main directory, contains script to build joinmarket on Ubuntu1204 VM and then to run enc_wrapper and regtest scripts (just to start of course).

I've connected Travis to my AdamISZ/joinmarket repo (it uses githooks) and it'll automatically test all pushes to my master branch. The tests are currently passing (You (@chris-belcher) can obviously do the same if and when it seems like a good idea.

Future plans in this regard: not sure what to do first, but probably add tests involving a larger number of bots and/or more and randomised transaction sizes. One stumbling block for testing other things (wallets, tumbler etc.) is have to create non-interactive versions (like -yes for sendpayment) which sits awkwardly with wallet creation for example (current bots cheat by using the seed option on test network).

Created an explanatory post here (since it can help with install): https://www.reddit.com/r/joinmarket/comments/3ek6qf/testing_and_setup_automation/

@chris-belcher
Copy link
Collaborator

Looking good.

Your reddit thread appears to be deleted (?)

@AdamISZ
Copy link
Member Author

AdamISZ commented Jul 27, 2015

As commit notes say, this is now testing basic wallet function (only generate and recover for now) also. Build is still passing. I can give you a url for an image to show passing/failing status if you like. As it turns out there is a cool Python module 'pexpect' that can handle shell interactivity very well (just using pipes isn't good enough for things like getpass), so that problem is solved. At some point I'll add some tests for wallet display and test out deposits etc.

chris-belcher added a commit that referenced this pull request Jul 30, 2015
Add travis for testing, testing files in test directory
@chris-belcher chris-belcher merged commit 1ddd19e into JoinMarket-Org:master Jul 30, 2015
ghtdak pushed a commit to ghtdak/joinmarket that referenced this pull request Oct 1, 2015
Add travis for testing, testing files in test directory
ghtdak pushed a commit to ghtdak/joinmarket that referenced this pull request Oct 4, 2015
Add travis for testing, testing files in test directory
ghtdak pushed a commit to ghtdak/joinmarket that referenced this pull request Dec 4, 2015
Add travis for testing, testing files in test directory
[gitreformat yapf-ify (github/ghtdak) on Fri Dec  4 04:50:29 2015]
[from commit: 1ddd19e]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants