This repository has been archived by the owner on May 13, 2022. It is now read-only.
refactor tests, small improvements #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional shell script is needed in some test cases; see IRC notes. |
chris-belcher
added a commit
that referenced
this pull request
Aug 23, 2015
refactor tests, small improvements
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 1, 2015
refactor tests, small improvements
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Oct 4, 2015
refactor tests, small improvements
ghtdak
pushed a commit
to ghtdak/joinmarket
that referenced
this pull request
Dec 4, 2015
refactor tests, small improvements [gitreformat yapf-ify (github/ghtdak) on Fri Dec 4 04:51:04 2015] [from commit: d6656c9]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commontest module for functions such as: populating wallets with coins, dealing with interactive command line input (using pexpect).
The former in particular will help with writing more sophisticated, generic tests (in particular, making sure you can test bots with "messier" wallet structures).
Note that this PR is independent of #187