This repository has been archived by the owner on May 13, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue that this addresses starts in #190 and continues/finishes in the reddit thread.
The fix is trivial, just checking that the seed phrase entered is 12 words. While doing it, I noticed that .split(' ') has the unfortunate effect of treating extra spaces as extra words (so 'a b c'.split(' ') comes out as ['a',b','','c'] which is undesirable if nothing else because it gives a misleading error). So I've edited it to .split() because this will split on any amount of whitespace, which is a more expected behaviour.
A perhaps more 'meta' conclusion from all this is to look again at sanity checking user input generally, and don't assume that used libraries (slowaes, old_mnemonic) are doing sanity checks at the lower level. I personally had never even looked at that code (even slowaes, although I used it before I never tried to use the high level 'encryptData' which does the padding for you).