Skip to content
This repository has been archived by the owner on May 17, 2022. It is now read-only.

Upgrade to v7.0.0 #6

Merged
merged 516 commits into from
Jul 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
516 commits
Select commit Hold shift + click to select a range
0449a3f
Delete an unused global (#3231)
koooge Jan 1, 2019
08b86c1
Fix: forked query wasn't opening in MULTI_ORG env (#3236)
arikfr Jan 1, 2019
8ea6283
Send argsrepr value with execute_query task (#3235)
arikfr Jan 1, 2019
cce2052
request.view_args might be None and add org_id to ApiUser (#3237)
arikfr Jan 1, 2019
8b5ffc6
Handle the case when a QueryTracker is None and change order. (#3238)
arikfr Jan 1, 2019
63f38b7
Fix: Query editor duplicates keystrokes [#2972] (#3239)
ranbena Jan 1, 2019
670d86e
Simple user view (#3244)
Jan 3, 2019
ba0d069
getredash/redash#3213 Scatter charts can have category Y axis (simila…
kravets-levko Jan 3, 2019
7a2e08c
Upgrade requests package (#3245)
kyoshidajp Jan 3, 2019
fc368ee
Support overriding the default Celery schedule database file via SCHE…
touchardv Jan 3, 2019
cdd2259
Closes #2396: Add finer-grained scheduling. (#2426)
Jan 6, 2019
3ee83a4
Feature: Refresh schedule - code optimizations
ranbena Jan 2, 2019
9b72dfe
Feature: Refresh schedule - save/cancel actions
ranbena Jan 2, 2019
b97b847
Feature: Refresh schedule - styling (#3247)
ranbena Jan 6, 2019
07a1c23
Fix: Able to set out-of-range refresh interval
ranbena Jan 3, 2019
569430e
Fix: Refresh schedule phrase overlaps title (#3250)
ranbena Jan 6, 2019
44dff83
Add "Active at" column to user list. (#3026)
jezdez Jan 7, 2019
823f172
Invitation Pending changes (#3229)
Jan 8, 2019
22f835d
client: Remove estraverse (#3254)
koooge Jan 8, 2019
08953cc
Redis based implementation of user active_at timestamp update (#3256)
arikfr Jan 8, 2019
a291360
update Flask-OAuthLib (#3262)
Jan 9, 2019
445f8e5
Fix invitation pending for existing users (#3261)
Jan 9, 2019
0b6f1fc
[Data Sources] Implement Apache Drill (#3188)
break-pointer Jan 10, 2019
de04a40
Fix: Refresh schedule interval count doesn't adhere to permission rul…
ranbena Jan 13, 2019
6c6366e
Fix: Refresh schedule durations not pluralized sufficiently (#3268)
ranbena Jan 13, 2019
26252be
Verify admin email address (#3267)
Jan 13, 2019
90a0a7d
Scheduler tests (jest/enzyme) (#3269)
ranbena Jan 13, 2019
200fea9
Pleasant alert-warning colors (#3276)
ranbena Jan 13, 2019
4c9326a
handlers: Fix post users (#3273)
koooge Jan 13, 2019
db86e39
Update Antd to latest version + fix tests (#3281)
kravets-levko Jan 14, 2019
d68a4dc
Pin version of pyparsing (#3282)
arikfr Jan 14, 2019
df23842
Separate Bootstrap/Ant styling (#3279)
gabrieldutra Jan 15, 2019
0c45d69
Dashboard Parameters (#2756)
kravets-levko Jan 15, 2019
823e4cc
Migrate DynamicForm to React (#3209)
gabrieldutra Jan 15, 2019
121a44e
Remove tree validations and introduce ParameterizedQuery (#3230)
Jan 17, 2019
7847cf7
Fix invitation pending for older invitations (#3298)
Jan 17, 2019
06887f6
Multifilter's dropdown cropped when visualization container is too small
kravets-levko Jan 17, 2019
40c6a26
Merge pull request #3299 from kravets-levko/fix/multifilter-dropdown
kravets-levko Jan 17, 2019
e8120c5
Use None as "not scheduled" default value of a query (#3277)
arikfr Jan 18, 2019
84d5bec
Update form text colors (#3296)
gabrieldutra Jan 20, 2019
8bc8e2d
Allow execution of highlighted subquery (#3288)
chang Jan 20, 2019
b91d4bd
override default integer/float formatting with environment variables …
chang Jan 20, 2019
b3643ff
Add regenerate function of user's API key (#3224)
kyoshidajp Jan 20, 2019
8bdcfb0
add wait time before percy data source page snapshot (#3320)
gabrieldutra Jan 22, 2019
c4bf446
Fix an error of exporting dict value as Excel (#3323)
kyoshidajp Jan 22, 2019
ff6b20b
support for fetching all JQL results by way of pagination (#3304)
justmiles Jan 22, 2019
7fa6665
Use Ant's Paginator component; migrate SortIcon to React (#3317)
kravets-levko Jan 22, 2019
a9c514a
Textless query result endpoint (#3311)
Jan 23, 2019
bfeb015
Add configuration for the Support probot. (#3327)
arikfr Jan 23, 2019
8766767
Remove link to roadmap (#3329)
arikfr Jan 23, 2019
d5afa18
Filtering out incompatible dashboard params (#3330)
ranbena Jan 23, 2019
1a61ee3
Add: Uptycs query runner (#3319)
vibhorkum Jan 23, 2019
c2c722e
Migrate PageHeader component to React (#3324)
kravets-levko Jan 23, 2019
b0b4d5e
Convert Angular services to CommonJS-style and use them in React comp…
kravets-levko Jan 24, 2019
d204c15
Allow query owners to hard-overwrite query content in case of overlap…
jezdez Jan 25, 2019
1fa5867
Refine SettingsMenu service and <settings-screen> component (#3339)
kravets-levko Jan 25, 2019
c31cb01
Move BigQueryGCE to its own file (#3356)
arikfr Jan 28, 2019
37821ee
Add Percy Page Screenshots (#3338)
gabrieldutra Jan 28, 2019
c085964
WIP: Add dashboard details section for dashboard owner and more (#2934)
kocsmy Jan 28, 2019
6930106
getredash/redash#3355 Widget params: Date/Date range value empty in s…
kravets-levko Jan 28, 2019
7278d4b
Refactor Policy and OrganizationStatus services (#3345)
kravets-levko Jan 28, 2019
ff42ec2
Cypress tests: preset the admin API key to a static value (#3358)
arikfr Jan 28, 2019
371b319
Server-side parameter validation (#3315)
Jan 29, 2019
2da5110
Frontend lint update (#3253)
koooge Jan 29, 2019
53aecdc
yandex_metrica: changed auth from params to headers (#3360)
Jan 29, 2019
61e7cda
Filename set when /results called directly (#3359)
aidarbek Jan 29, 2019
9e2f8e2
Fix: Escape button in tag edit modal (#3363)
ranbena Jan 30, 2019
13bc910
Update CodeClimate configuration format to Version 2 (#3286)
koooge Jan 30, 2019
0b9f575
Fix: make ClickHouse password and username truly optional (#3362)
aidarbek Jan 30, 2019
0d95911
Migrate FavoritesControl component to React
kravets-levko Jan 30, 2019
9a1c829
Migrate TagsList component to React
kravets-levko Jan 30, 2019
1ea532f
CR1
kravets-levko Jan 30, 2019
a362e97
CR2
kravets-levko Jan 30, 2019
00e991e
Fix: Static param value not editable for Text/Number (#3369)
ranbena Jan 30, 2019
225c98c
Merge branch 'master' into feature/react-favorites-and-tags-list
kravets-levko Jan 30, 2019
0674726
CR3
kravets-levko Jan 30, 2019
cc13539
Fix: static param text value is `[object Object]` (#3371)
ranbena Jan 30, 2019
3ad1709
Merge branch 'master' into feature/react-favorites-and-tags-list
kravets-levko Jan 30, 2019
4a2645d
Merge pull request #3368 from kravets-levko/feature/react-favorites-a…
kravets-levko Jan 30, 2019
c51191a
Tune CodeClimate's config to make it less annoying (#3370)
arikfr Jan 31, 2019
bd559b6
Fix some incompatible dependencies (#3348)
jezdez Jan 31, 2019
ee0e81e
Fix eslint errors
kravets-levko Jan 31, 2019
f98cf78
Merge branch 'master' into fix-eslint-errors
kravets-levko Jan 31, 2019
9c06e9a
CR1
kravets-levko Jan 31, 2019
1439714
Migrate EmptyState component to React (#3373)
kravets-levko Jan 31, 2019
c223566
Merge branch 'master' into fix-eslint-errors
kravets-levko Jan 31, 2019
3d58860
Merge pull request #3374 from kravets-levko/fix-eslint-errors
kravets-levko Jan 31, 2019
ebb96d7
Widget param url prefix p to p_w (#3380)
ranbena Jan 31, 2019
35c390a
Show disabled unpublished queries for alert and dashboard modals. (#3…
Jan 31, 2019
feab2a0
BigQuery should correctly handle tmp tables that do not have a schema…
Jan 31, 2019
9859610
Alternative implementation: Step component
arikfr Jan 31, 2019
f957055
Bring back data sources step for non admins
arikfr Jan 31, 2019
a1cf065
No need to export Step
arikfr Jan 31, 2019
e314715
Refine implementation, fix 'shouldShow' condition, fix eslint warnings
kravets-levko Feb 1, 2019
78df7e7
Last refinements:
arikfr Feb 1, 2019
fde52f5
Fix Cypress E2E failing in CI
gabrieldutra Feb 2, 2019
10b5c03
Merge pull request #3389 from getredash/cypress
kravets-levko Feb 2, 2019
aa619c4
Merge branch 'master' into step-component
kravets-levko Feb 2, 2019
abccff0
Fix Add datasource step; EmptyState.icon is optional
kravets-levko Feb 2, 2019
324a1f5
Merge pull request #3384 from getredash/step-component
kravets-levko Feb 2, 2019
807e6aa
Migrate "time ago" components to React (#3385)
kravets-levko Feb 2, 2019
b0a1198
fix lint error - getDerivedStateFromProps should be placed after stat…
Feb 3, 2019
69e34f0
Add archived queries section to queries list. (#2888)
jezdez Feb 3, 2019
3992bcd
Ignore to copy some files onto docker container (#3388)
koooge Feb 3, 2019
933dd75
Make the logic around schedule['until'] easier to read (#3376)
arikfr Feb 3, 2019
3df3724
[Widget Params] Migrated edit params + new widget dialog to Ant Moda…
ranbena Feb 4, 2019
8f0cffe
Use textless endpoint for pristine queries (#3367)
Feb 5, 2019
2011864
Fix: Selected item in dropdown unreadable (#3398)
ranbena Feb 5, 2019
7cfea8a
Fix: only login user when it's the current user. (#3396)
arikfr Feb 5, 2019
c9681d5
Added pre-push hook (#3390)
ranbena Feb 5, 2019
5b62883
[Widget Params] Switched parameter list to table style (all parts) (#…
ranbena Feb 5, 2019
1385593
Add YAML support in QueryEditor (#3395)
arikfr Feb 5, 2019
ac68fe1
Migrate Dashboards/Queries/Users list pages to React (#3381)
kravets-levko Feb 5, 2019
2134113
Fix: cohorts get stuck when passing strings instead of numbers. (#3397)
arikfr Feb 5, 2019
045c171
Refactor TagsControl; fix TagsEditorModal animation (#3399)
kravets-levko Feb 5, 2019
ec475e4
[Bug fix] Few small bugs on Queries list page (#3402)
kravets-levko Feb 5, 2019
029bee1
Coerce to moment when 'datetime' selected by user. (#3150)
Feb 7, 2019
c49dccf
Work around a resizing issue. (#3412)
jezdez Feb 7, 2019
11507c5
Show active and pending users separately (for admins) (#3400)
kravets-levko Feb 7, 2019
593ebde
Fix: “Add TextBox” dialog not opening (#3414)
ranbena Feb 7, 2019
29326f3
[Widget Params] Title edit fixes (#3413)
ranbena Feb 8, 2019
23f5dde
[Codebase Improvement] Refine dialog wrapper and use it for all exist…
kravets-levko Feb 8, 2019
e21bbcc
[UI/UX Improvement] Use Ant's Button component on users list page (#3…
kravets-levko Feb 8, 2019
03f040d
Unify query based dropdown population (#3337)
Feb 10, 2019
df4ca86
Added short modal specific styling (#3366)
ranbena Feb 10, 2019
23908ed
Handle InterruptException in Athena query runnner like in the Presto …
jezdez Feb 10, 2019
71fb144
Upgrade Sentry SDK (#3418)
Feb 10, 2019
eee77a1
[Bug fix] Show query result footer only when there is a query result.…
arikfr Feb 11, 2019
cb22764
Bug fix] Saving a new query removes reference to last query result (#…
arikfr Feb 11, 2019
2c1400d
[Feature] Alternative implementation of dashboard param title editing…
kravets-levko Feb 11, 2019
330c5a8
Enable remote debugging with ptvsd (#3419)
Feb 12, 2019
4dbc175
Converted Share modal to Ant (#3424)
ranbena Feb 12, 2019
d567765
[Bug fix] Notifications randomly shown with visible page or not shown…
kravets-levko Feb 12, 2019
3fed697
[Bug fix] Query Parameters: don't save urlPrefix (#3427)
kravets-levko Feb 12, 2019
901f28a
Pre-commit hook to run on modified files only (#3410)
ranbena Feb 13, 2019
9b1f277
[Widget Params] Updated help url and tooltip (#3428)
ranbena Feb 13, 2019
c028e49
send ip and user id to sentry (#3430)
Feb 13, 2019
d6827e3
Version update time ⏰ (#3429)
arikfr Feb 13, 2019
f2df717
HelpTrigger (#3431)
ranbena Feb 13, 2019
afaedb9
[Feature] Table visualization: Raise the upper limit of MAX_JSON_SIZE…
swfz Feb 13, 2019
b9644b7
React version of UserEdit (#3354)
gabrieldutra Feb 14, 2019
fba2a35
[Feature] Sharing disabled if dashboard has query params (#3439)
ranbena Feb 16, 2019
58a53e3
Fix: remove widgets when deleting a visualization. (#3423)
arikfr Feb 17, 2019
a8f74a1
remove the word "type" from error message, as enum out-of-range error…
Feb 17, 2019
a34269c
Change: encrypt data source options. 🔓 (#2970)
arikfr Feb 17, 2019
81c9504
HelpTrigger to open in drawer (#3436)
ranbena Feb 17, 2019
60472e2
Add support for Amazon ES service with IAM authentication (#3446)
arikfr Feb 17, 2019
f07e613
Fix: ScheduleDialog won't render for "30 days" interval with no time …
arikfr Feb 17, 2019
298fe6a
HelpTrigger in header (#3457)
ranbena Feb 18, 2019
d483785
[Codebase improvement] Refine ItemsList base component (previously Li…
kravets-levko Feb 18, 2019
2c70571
Fixes to Percy (#3440)
gabrieldutra Feb 18, 2019
3147a0b
Version data - footer -> header menu (#3458)
ranbena Feb 18, 2019
8fc2ecf
[Bug fix] Widget oblivious to updated parameter values (#3445)
ranbena Feb 18, 2019
ebef0ef
Fix: timedelta values were not JSON serialized properly (#3463)
arikfr Feb 19, 2019
f421119
Remove options NullPool does not support (#3460)
arikfr Feb 19, 2019
0bca2d8
when working with a schema, fail in the case that there are parameter…
Feb 19, 2019
e35f2b8
Fix: when max_age is None the handler fails (#3462)
arikfr Feb 19, 2019
fe10b06
Fix: JS Map needs a set call rather than assignment (#3464)
arikfr Feb 20, 2019
77dcc80
Fix: ParameterizedQuery: support for upper cases column names. (#3461)
arikfr Feb 20, 2019
1ad0fa6
avoid Flask debug error message about strict slashes (#3469)
Feb 20, 2019
a17eb14
support e-mail verification for multi org setups (#3468)
Feb 20, 2019
8b19f16
Help trigger dynamic component (#3472)
ranbena Feb 20, 2019
4999ab5
Provide default value for .pop to avoid KeyError exception (#3474)
arikfr Feb 21, 2019
8fe1d33
monitor "schemas" queue to run refresh_schema (#3459)
koron Feb 21, 2019
4ad303b
Fix some flex layout issue (#3476)
ranbena Feb 21, 2019
2a37cb3
Fix max-age issues on textless endpoint (#3477)
Feb 21, 2019
8679b87
Cleaner approach for _is_collection_a_view (#3113)
jodevsa Feb 21, 2019
33b8bd2
[Feature] Migrate Group List and Details pages to React (#3411)
kravets-levko Feb 22, 2019
5e5b0d6
[Feature, Tech debt] Improve list pages layout (#3482)
kravets-levko Feb 22, 2019
5d525b8
fix broken link in CONTRIBUTING.md (#3483)
taminif Feb 22, 2019
3fdd308
Use series name as pie chart label (#3484)
Feb 25, 2019
f4f34d0
Create PULL_REQUEST_TEMPLATE.md (#3485)
arikfr Feb 25, 2019
d36e5ac
Fix update logo (#3489)
yoshiken Feb 25, 2019
1a357df
Fix prometheus query runner: get_schema and query range (#3471)
veerkat Feb 25, 2019
b56cc1c
Pin SQLAlchemy-Utils version (#3490)
arikfr Feb 25, 2019
75c34bf
Add custom JSON encoder for PostgreSQL (#3442)
s22su Feb 25, 2019
5c5bfbd
Make sure Flask app created in Celery's worker process (#3465)
arikfr Feb 25, 2019
60cd881
Update Percy token (#3492)
gabrieldutra Feb 25, 2019
138c55c
Fix DynamicForm ignoring default value for checkboxes (#3487)
gabrieldutra Feb 26, 2019
0d76c03
Be more permissive when parameters are safe (#3383)
Feb 26, 2019
570e8d9
set invitation as not-pending in render_token_login_page only when (#…
Feb 27, 2019
fbaded4
adding gevent worker in requirements.txt, adding some gunicorn config…
ialeinikov Feb 27, 2019
e9c88ea
Verify address when users change their e-mail (#3504)
Feb 27, 2019
c9a4f07
Support AWS IAM profile for Amazon Elasticsearch (#3005)
tilfin Feb 28, 2019
83668a6
LDAP Authentication. Create two envars REDASH_LDAP_USE_SSL and REDASH…
MrCirca Feb 28, 2019
194f452
[Feature] Migrate Alerts List Page to React (#3505)
gabrieldutra Feb 28, 2019
549f878
Added <QuerySelector /> component (#3494)
ranbena Feb 28, 2019
a93741e
CircleCI build improvements (#3511)
arikfr Feb 28, 2019
dab35ac
QuerySelector in Alert page (#3501)
ranbena Feb 28, 2019
34e03b0
Migrated query edit/add param dialog to React/AntD/Hooks (#3488)
ranbena Feb 28, 2019
6e3b9c2
Fixed navbar responsiveness (#3510)
ranbena Feb 28, 2019
02e82a7
Fix verification_email endpoint when in MULTI_ORG mode (#3502)
Mar 2, 2019
ade3cc7
Fix eslint error on AlertsList (#3518)
gabrieldutra Mar 2, 2019
dd0fab7
Moved widget and dashboard save logic out of dialog (#3522)
ranbena Mar 4, 2019
34da15f
Migrated AddTextboxDialog to AntD (#3524)
ranbena Mar 4, 2019
6a75ac4
Migrate User Pages to React (#3506)
gabrieldutra Mar 4, 2019
7a4fe50
Added UTC display to scheduler dialog (#3517)
ranbena Mar 5, 2019
bc22797
[Refactor] Refine New user modal (#3529)
kravets-levko Mar 5, 2019
b68051d
Add Hangouts Chat as alert destination (#3525)
pieter-venter Mar 5, 2019
4e7d16b
Remove Flask-Admin. (#3532)
jezdez Mar 6, 2019
21082fb
Make the "celery" queue the default instead of "schema" to stay backw…
jezdez Mar 6, 2019
75bc469
Remove duplicate column information for late-binding views (#3537)
paulgraff Mar 6, 2019
8eb751f
Remove docker-compose.production.yml in favor of setup/docker-compose…
jezdez Mar 6, 2019
160c3c1
Param fix (#3528)
ranbena Mar 6, 2019
4f79c86
Pin pymapd version to 0.7.1 (#3543)
arikfr Mar 7, 2019
507ea61
Fix long tag labels breaking table layout (#3545)
ranbena Mar 7, 2019
be1bd28
[Bug fix] Wrong behavior when clicking table rows on list pages (#3540)
kravets-levko Mar 7, 2019
e4c933a
Update PULL_REQUEST_TEMPLATE.md (#3549)
arikfr Mar 7, 2019
dfa48ca
Fix: order dashboard favorites (#3552)
arikfr Mar 7, 2019
8737e80
Add: Docker entrypoint to do Celery healthchecks. (#3548)
arikfr Mar 7, 2019
61f143d
Snowflake: add support for regions and enable by default (#3550)
arikfr Mar 7, 2019
5501f3e
Upgrade jest & babel (#3405)
koooge Mar 10, 2019
12d2a04
Download Query Result links: use query name for downloaded filename (…
kravets-levko Mar 10, 2019
26f0ce0
New Celery/Queries Execution Status API (#3057)
arikfr Mar 10, 2019
b703f7a
Create weekly-digest.yml
arikfr Mar 10, 2019
5dc74e1
npm audit fixes (#3561)
ranbena Mar 10, 2019
4cfa26a
[Bug fix] Handle errors on Group members, Group datasources and User …
kravets-levko Mar 10, 2019
685c771
Update Amazon Elasticsearch Service image (#3567)
gabrieldutra Mar 11, 2019
63d3f22
Convert all dropdown values to strings to support parameter lookup (#…
Mar 11, 2019
93ec19b
Prevent blank edit-in-place value (#3557)
ranbena Mar 11, 2019
5943bf0
change the order of configuration of the Elasticsearch data source to…
Mar 12, 2019
fbf4dae
Fix webpack config to work with symlinks (#3573)
kravets-levko Mar 12, 2019
ba62b46
Append "UTC" to timestamp on embeds (in print view) (#3574)
arikfr Mar 13, 2019
4a8d9a7
Fork query does not fork tables but instead adds default table (#3580)
kravets-levko Mar 13, 2019
4768fd0
Add SAML scheme override env var (#2947)
leosunmo Mar 13, 2019
f1cb010
👋 goodbye, similar-code false positives. (#3578)
arikfr Mar 13, 2019
adf935b
Fix for parameter mapping bug #3581 (#3582)
ranbena Mar 13, 2019
cb4d81d
Schema Viewer Drawer (#3291)
Mar 13, 2019
b799ab6
Added alt+enter key binding (#3479)
ranbena Mar 14, 2019
ab39242
Cypress test - dashboard create/archive (#3565)
ranbena Mar 14, 2019
8456bbf
Revert "Schema Viewer Drawer (#3291)" (#3585)
jezdez Mar 14, 2019
10f4b99
Widget title link not updated when parameter value changes (#3586)
kravets-levko Mar 14, 2019
cf5c2c5
Revert "Add SAML scheme override env var (#2947)" (#3587)
arikfr Mar 14, 2019
852636f
update to latest stable version (#3588)
bmaeser Mar 14, 2019
a8cb709
[Codebase improvement] Reuse handlers base require_fields (#3577)
Feeeenng Mar 15, 2019
1f74c0b
[Bug fix] Update user list when an user is created (#3594)
gabrieldutra Mar 15, 2019
93aa6b5
Fix: accept integer values in dropdowns. (#3596)
arikfr Mar 17, 2019
e5d082b
Textbox testing - add, remove, edit (#3589)
ranbena Mar 17, 2019
ff0967f
Update v7 CHANGELOG and version (#3595)
arikfr Mar 17, 2019
4a978ba
Fix: triggers not created for queries.search_vector (#3634)
arikfr Mar 24, 2019
7c2c520
Prepared for deployment to Aptible
dangrahn Jul 3, 2017
341a717
Fix: CircleCI release branch regex
arikfr Sep 24, 2018
b35fc7f
Do not attempt to create dashboard.tags
axeltlarsson Nov 22, 2018
1c51c42
Add ja-redash-specific documentation
axeltlarsson Nov 22, 2018
8b6c825
Fix doc.md indentation
axeltlarsson Nov 22, 2018
7215eee
Correct the upgrade instructions
axeltlarsson Nov 22, 2018
60fbcd9
Update visualisations' colour palette
axeltlarsson Nov 22, 2018
4ec11b3
Attempt to mitigate ImportError bytes_type
axeltlarsson Jan 28, 2019
30d6a4b
Fix some rebase issues
axeltlarsson Jul 26, 2019
3ce5c0f
Merge branch 'master' into upgrade-redash-v7
axeltlarsson Jul 26, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
getredash#3213 Scatter charts can have category Y axis (similar to Bu…
…bble) (getredash#3243)
kravets-levko authored Jan 3, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ba0d06928318a4926d81251fc658d33b234ba2db
6 changes: 3 additions & 3 deletions client/app/visualizations/chart/plotly/utils.js
Original file line number Diff line number Diff line change
@@ -429,9 +429,9 @@ function prepareChartData(seriesList, options) {
// Sort by x - `Map` preserves order of items
const data = sortX ? sortBy(series.data, d => normalizeValue(d.x)) : series.data;

// For bubble charts `y` may be any (similar to `x`) - numeric is only bubble size;
// For bubble/scatter charts `y` may be any (similar to `x`) - numeric is only bubble size;
// for other types `y` is always number
const cleanYValue = seriesOptions.type === 'bubble' ? normalizeValue : cleanNumber;
const cleanYValue = includes(['bubble', 'scatter'], seriesOptions.type) ? normalizeValue : cleanNumber;

const sourceData = new Map();
const xValues = [];
@@ -639,7 +639,7 @@ function updateSeriesText(seriesList, options) {
};
const item = series.sourceData.get(x);
if (item) {
text['@@y'] = seriesOptions.type === 'bubble' ? item.y : series.formatNumber(item.y);
text['@@y'] = includes(['bubble', 'scatter'], seriesOptions.type) ? item.y : series.formatNumber(item.y);
if (item.yError !== undefined) {
text['@@yError'] = series.formatNumber(item.yError);
}