Fix getName callback response unneeded deserialization #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current proxied getName callback is broken. The data returned by user-provided callback is passed to IPC as is:
tdl-multiprocess/lib/Client.js
Line 68 in 01fde12
tdl-multiprocess/lib/Client.js
Lines 39 to 41 in 01fde12
but then the child tries to parse it as JSON (and crashes):
tdl-multiprocess/lib/Child.js
Lines 73 to 78 in 01fde12
The account registration is therefore broken with tdl-mutltiprocess.
The PR removes the unneeded deserialization (honestly, I'm not sure why do you want to serialize other request/responses..
node-ipc-promise
seems to be doing that already just fine.)