Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved dx, typed library, comments #6

Merged
merged 8 commits into from
Oct 26, 2023
Merged

refactor: improved dx, typed library, comments #6

merged 8 commits into from
Oct 26, 2023

Conversation

a-rustacean
Copy link
Collaborator

@a-rustacean a-rustacean commented Aug 9, 2023

I refactored the code, improved the readme, eliminated the deprecated request dependency, introduced axios due to its larger community, incorporated JSDoc comments, eliminated unnecessary recursion, utilized modern and efficient language features like Promise.all, excluded node_modules as it's not necessary for npm, provided a custom domain option for TempMail (#7 was unnecessary), and introduced eslint, prettier, husky, lint-staged, and npm-scripts to enhance the developer experience.

@a-rustacean a-rustacean changed the title Refactored code Added custom domain option on Tempmail and Refactored code Sep 10, 2023
@a-rustacean a-rustacean changed the title Added custom domain option on Tempmail and Refactored code Enhancements and Refactoring for Improved Developer Experience Sep 10, 2023
@Jon-Becker
Copy link
Owner

Hey! I got your email. I don't check this repository too often for PRs, but I will in the future.

I'll review this today and merge it in if all is well. I'll also probably set up a test suite, and add other services so that the library works with more than one temp mail service.

Thank you for your contribution, I appreciate it!

Copy link
Owner

@Jon-Becker Jon-Becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please don't remove preview.png, its used by some external services I believe. I can make the npm module ignore it though.

I'll also make a few changes here before merging.

@Jon-Becker Jon-Becker self-assigned this Sep 12, 2023
@Jon-Becker Jon-Becker mentioned this pull request Sep 12, 2023
@Jon-Becker Jon-Becker changed the title Enhancements and Refactoring for Improved Developer Experience refactor: improved dx, typed library, comments Sep 12, 2023
@a-rustacean
Copy link
Collaborator Author

Certainly, I've readded the preview.png file as per your request. Thank you for your quick response and assistance!

@a-rustacean
Copy link
Collaborator Author

Could you kindly review the changes I've made?

@Jon-Becker Jon-Becker merged commit 78700ee into Jon-Becker:master Oct 26, 2023
@Jon-Becker
Copy link
Owner

i'll make a release after testing thoroughly :)

if you would like to be made a contributor here, since I don't manage this repo much, let me know!

@a-rustacean
Copy link
Collaborator Author

I'd be happy to be a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants