-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improved dx, typed library, comments #6
Conversation
Hey! I got your email. I don't check this repository too often for PRs, but I will in the future. I'll review this today and merge it in if all is well. I'll also probably set up a test suite, and add other services so that the library works with more than one temp mail service. Thank you for your contribution, I appreciate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please don't remove preview.png
, its used by some external services I believe. I can make the npm module ignore it though.
I'll also make a few changes here before merging.
Certainly, I've readded the |
Could you kindly review the changes I've made? |
i'll make a release after testing thoroughly :) if you would like to be made a contributor here, since I don't manage this repo much, let me know! |
I'd be happy to be a contributor. |
I refactored the code, improved the readme, eliminated the deprecated
request
dependency, introducedaxios
due to its larger community, incorporated JSDoc comments, eliminated unnecessary recursion, utilized modern and efficient language features likePromise.all
, excludednode_modules
as it's not necessary for npm, provided a custom domain option forTempMail
(#7 was unnecessary), and introducedeslint
,prettier
,husky
,lint-staged
, andnpm-scripts
to enhance the developer experience.