-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Vite's base
config when using the dev server
#489
Conversation
Whoops.
What in the world...
🦋 Changeset detectedLatest commit: a0f8876 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #489 +/- ##
=======================================
Coverage 96.74% 96.75%
=======================================
Files 31 31
Lines 1107 1109 +2
Branches 222 222
=======================================
+ Hits 1071 1073 +2
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Is there anything else you'd like me to do before this can be merged? My current workaround involves manually building |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
It adds support for Vite's
base
config in the dev server. This fixes issues with serving assets through imagetools when using a custom backend, such as Rails.Fixes #396.
The URL prefix used to watch for imagetools requests is now
${viteConfig.base}/@imagetools/
instead of just/@imagetools/
. This allows for things like Rails to properly forward those requests to the Vite dev server.PR?)
I don't think so, no.