Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "inline" directive #672

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

pzerelles
Copy link
Contributor

  • Quick Checklist
  • I have read the contributing guidelines
  • I have written new tests, as applicable (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • I have added a changeset, if applicable
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the new behavior (if this is a feature change)?
    images can be inlined with the inline directive

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this
    PR?)
    no

  • Other information:
    fixes Add support for inlined images by respecting the ?inline suffix #253

Copy link

changeset-bot bot commented Dec 10, 2023

🦋 Changeset detected

Latest commit: 126edda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vite-imagetools Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.64%. Comparing base (dc25e4b) to head (126edda).

Files Patch % Lines
packages/vite/src/index.ts 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   93.61%   93.64%   +0.03%     
==========================================
  Files          32       32              
  Lines        1190     1196       +6     
  Branches      190      193       +3     
==========================================
+ Hits         1114     1120       +6     
  Misses         76       76              
Flag Coverage Δ
imagetools-core 93.64% <66.66%> (+0.03%) ⬆️
vite-imagetools 93.64% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pzerelles pzerelles force-pushed the inline-directive branch 2 times, most recently from 934e6d4 to b6b8fe9 Compare March 27, 2024 07:03
docs/directives.md Outdated Show resolved Hide resolved
@benmccann benmccann merged commit 7542fa5 into JonasKruckenberg:main Mar 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for inlined images by respecting the ?inline suffix
2 participants