-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang format #1273
base: dev-v1.0
Are you sure you want to change the base?
Clang format #1273
Conversation
We could also add clang-format checks to CI |
I could do that but its best to have all of the files formatted first |
Thanks for this MR,
Before updating all files, we should first agree on a format :). I will play with the example you provided and get back to you as soon as I can. |
Definitely, that is also what I meant.
No rush here, thanks for looking into it. |
This is a nice addition :) @ZehMatt Could you modify the PR so it merges into |
Not sure why GitHub decided to pick master, I branched off dev-1.0 🤷♂️ , changed it. |
Thanks, @ZehMatt ! |
I've tried to minimize the diff but also didn't want to exactly match it to get somewhere in the middle of readability and consistency. I also enabled the option to auto comment the end of the namespace, this is a bit inconsistent at the moment and we should either turn that option off or remove the ones that don't fit, I personally think its best to let clang-format do the commenting so it won't be missed and it will be consistent across the board.
Probably need a few more files I should look into, clang-format can get quite notorious about tables.