Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of pkg_resources #245

Closed
JonathonReinhart opened this issue Jan 2, 2024 · 2 comments · Fixed by #247
Closed

Remove use of pkg_resources #245

JonathonReinhart opened this issue Jan 2, 2024 · 2 comments · Fixed by #247

Comments

@JonathonReinhart
Copy link
Owner

JonathonReinhart commented Jan 2, 2024 •
edited
Loading

https://setuptools.pypa.io/en/latest/pkg_resources.html

https://importlib-resources.readthedocs.io/en/latest/migration.html

https://phabricator.wikimedia.org/T340640

googleapis/python-api-core#27
https://github.com/googleapis/python-api-core/pull/80/files

fralau/mkdocs-macros-plugin#157

https://docs.python.org/3/whatsnew/3.12.html#:~:text=This%20means%20that%20distutils%2C%20setuptools%2C%20pkg_resources%2C%20and%20easy_install%20will%20no%20longer%20available%20by%20default
This was referenced Jan 2, 2024
Merged
Closed
@JonathonReinhart
Copy link
Owner Author

The replacement for pkg_resources.get_distribution(DIST_SPEC).version is importlib.metadata.version(DIST_SPEC).

However, importlib.metadata is not available until Python 3.8 and our minimum is Python 3.7 (until #242).

JonathonReinhart added a commit that referenced this issue Jan 3, 2024
@JonathonReinhart
scuba: Use importlib.metadata over pkg_resources
adff272 
pkg_resources is deprecated.

Fixes #245
@JonathonReinhart JonathonReinhart mentioned this issue Jan 3, 2024
Merged
@JonathonReinhart
Copy link
Owner Author

python/mypy#1153 (comment)

JonathonReinhart added a commit that referenced this issue Jan 3, 2024
@JonathonReinhart
scuba: Use importlib.metadata over pkg_resources for getting version
a9f4e19 
pkg_resources is deprecated:
https://setuptools.pypa.io/en/latest/pkg_resources.html

This prefers importlib.metadata (introduced in Python 3.8) and uses the
backport importlib_metadata for Python 3.7 (to be removed in #242).

Fixes #245
JonathonReinhart added a commit that referenced this issue Jan 3, 2024
@JonathonReinhart
scuba: Use importlib.metadata over pkg_resources for getting version
b9cc16a 
pkg_resources is deprecated:
https://setuptools.pypa.io/en/latest/pkg_resources.html

This prefers importlib.metadata (introduced in Python 3.8) and uses the
backport importlib_metadata for Python 3.7 (to be removed in #242).

Fixes #245
JonathonReinhart added a commit that referenced this issue Jan 3, 2024
@JonathonReinhart
scuba: Use importlib.metadata over pkg_resources for getting version
c5c5233 
pkg_resources is deprecated:
https://setuptools.pypa.io/en/latest/pkg_resources.html

This prefers importlib.metadata (introduced in Python 3.8) and uses the
backport importlib_metadata for Python 3.7 (to be removed in #242).

Fixes #245
JonathonReinhart added a commit that referenced this issue Jan 3, 2024
@JonathonReinhart
scuba: Use importlib.metadata over pkg_resources for getting version (#…
0447700 
…247)

pkg_resources is deprecated:
https://setuptools.pypa.io/en/latest/pkg_resources.html

This prefers importlib.metadata (introduced in Python 3.8) and uses the
backport importlib_metadata for Python 3.7 (to be removed in #242).

Fixes #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scuba: Use importlib.metadata over pkg_resources JonathonReinhart/scuba
1 participant
@JonathonReinhart