Remove --fast-toc from cdrdao's options
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my personal usage `--fast-toc` almost always results in isrcsubmit.py finding duplicate ISRCs. Removing `--fast-toc` makes the reading significantly slower, but it also means that it doesn't get duplicate ISRCs meaning it only needs to run once.
|
Had an issue with a CD where isrcsubmit.py kept reporting multiple tracks sharing the same ISRC, no matter how many times I tried using both cdrdao and libdiscid. This patch solved the issue immediately. Strongly recommend including it, if not as a default then at least as possible flag option when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my personal usage
--fast-tocalmost always results in isrcsubmit.py finding duplicate ISRCs. Removing--fast-tocmakes the reading significantly slower, but it also means that it doesn't get duplicate ISRCs meaning it only needs to run once.