feat: refactor code, add dependabot, and bump to v1.6.4 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonxslays
reviewed
Jul 16, 2023
There was a problem hiding this comment.
It looks like updating decancer is causing some tests to fail. Can you take a look at that? I think there were breaking changes between decancer 1.5.2 and 1.6.4. If not I will be able to investigate and merge with updates tonight. Thanks for the contribution either way, @null8626!
Jonxslays
requested changes
Jul 16, 2023
|
A bit strange for you to merge the Pull Request immediately without letting me fix the unresolved failing tests, but thank you! <3 |
|
Yeah i had planned to just take care of it if it wasn't done by this evening. It ended up just being a python dev dependency issue, not even an issue with the tests or decancer. Thanks again for bringing it up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request bumps the
decancerdependency to versionv1.6.4(closes #3). It also fixes a vulnerability that was fixed in versionv1.6.3.Other than that, this pull request also adds
dependabotthat makes sure your cargo dependencies are up to date every Sunday at 6am UTC.Thank you for supporting
decancer! ❤️