forked from aws/aws-cli
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use default value getattr when checking for paging params
When checking to make sure that no paging params are set, we did not account for the possibility that page size isn't present for a given operation. Thus, errors would be raised when `--no-paginate` was supplied on operations without it. This sets a default value to the getattr call to prevent the error. Fixes aws#1993
- Loading branch information
1 parent
87d03e6
commit d775ed4
Showing
3 changed files
with
28 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"description": "Fixed a bug where specifying `--no-paginate` on an operation without a page size parameter raised an error. Fixes `#1993 <https://github.com/aws/aws-cli/issues/1993>`__.", | ||
"category": "Paginator", | ||
"type": "bugfix" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Copyright 2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You | ||
# may not use this file except in compliance with the License. A copy of | ||
# the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific | ||
# language governing permissions and limitations under the License. | ||
from awscli.testutils import BaseAWSCommandParamsTest | ||
|
||
|
||
class TestDescribeStacks(BaseAWSCommandParamsTest): | ||
|
||
prefix = 'cloudformation describe-stacks' | ||
|
||
def test_no_paginate(self): | ||
cmdline = self.prefix + ' --no-paginate' | ||
self.assert_params_for_cmd(cmdline) |