Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new data fields to the liquidation visibility #36

Open
anilhelvaci opened this issue Jun 14, 2024 · 0 comments
Open

Add new data fields to the liquidation visibility #36

anilhelvaci opened this issue Jun 14, 2024 · 0 comments
Assignees
@anilhelvaci @Jorge-Lopes
Labels
enhancement New feature or request

Comments

@anilhelvaci
Copy link
Collaborator

What is the Problem Being Solved?

Agoric OpCo requested new fields to be displayed.

Description of the Design

New data will be added to auctionResult storage node. Here are the requested data;

  • debtToBurn
  • mintedeForReserve
  • totalPenalty

Security Considerations

None

Scaling Considerations

None

Test Plan

Update existing tests to check for these data as well. Make sure values are correct.

Upgrade Considerations

These changes will be included in core-eval vaultFactory upgrade
@anilhelvaci anilhelvaci added the enhancement New feature or request label Jun 14, 2024
@anilhelvaci anilhelvaci self-assigned this Jun 14, 2024
@anilhelvaci anilhelvaci mentioned this issue Jun 14, 2024
Open
@Jorge-Lopes Jorge-Lopes self-assigned this Jun 19, 2024
Jorge-Lopes added a commit that referenced this issue Jun 19, 2024
@Jorge-Lopes
feat(liquidationVisibility): add new data fields to the auctionResult…
0e6223f 
…State

Ref: #36
Jorge-Lopes added a commit that referenced this issue Jun 19, 2024
@Jorge-Lopes
test(liquidationVisibility): update unit tests and snapshot for new a…
be3f25c 
…uctionResultState data fields

Ref: #36
Jorge-Lopes added a commit that referenced this issue Jun 19, 2024
@Jorge-Lopes
test(liquidationVisibility): update bootstrap snapshot for new auctio…
6840c8c 
…nResultState data fields

Ref: #36
@Jorge-Lopes Jorge-Lopes mentioned this issue Jun 20, 2024
Merged
anilhelvaci added a commit that referenced this issue Jun 20, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
b18479a 
TODO: Update bootstrap tests as well

Refs: #35 #36
Jorge-Lopes added a commit that referenced this issue Jun 21, 2024
@Jorge-Lopes
chore(liquidationVisibility): update LiquidationOutcome and expected …
57acbf9 
…auctionResult with new data fields

Ref: #35 and #36
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Update bootstrap tests
1403b69 
Refs: #35 #36
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
5748fe3 
TODO: Update bootstrap tests as well

Refs: #35 #36
anilhelvaci pushed a commit that referenced this issue Jun 21, 2024
@Jorge-Lopes @anilhelvaci
chore(liquidationVisibility): update LiquidationOutcome and expected …
1b6e567 
…auctionResult with new data fields

Ref: #35 and #36
anilhelvaci added a commit that referenced this issue Jun 21, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
ce09411 
TODO: Update bootstrap tests as well

Refs: #35 #36
anilhelvaci pushed a commit that referenced this issue Jun 21, 2024
@Jorge-Lopes @anilhelvaci
chore(liquidationVisibility): update LiquidationOutcome and expected …
2d3f580 
…auctionResult with new data fields

Ref: #35 and #36
anilhelvaci added a commit that referenced this issue Jul 15, 2024
@anilhelvaci
chore(liquidationVisibility): Add new data fields
0fa050f 
TODO: Update bootstrap tests as well

Refs: #35 #36
anilhelvaci pushed a commit that referenced this issue Jul 15, 2024
@Jorge-Lopes @anilhelvaci
chore(liquidationVisibility): update LiquidationOutcome and expected …
c013902 
…auctionResult with new data fields

Ref: #35 and #36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anilhelvaci anilhelvaci

@Jorge-Lopes Jorge-Lopes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anilhelvaci @Jorge-Lopes