Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchestration API support of NFTs #34

Open
wants to merge 6 commits into
base: orchestration-develop
Choose a base branch
from

Conversation

Jorge-Lopes
Copy link
Owner

@Jorge-Lopes Jorge-Lopes commented Jun 6, 2024

refs: #33

Description

This PR aims to extend the Agoric Orchestration package to support the cosmos NFT module, more specifically, providing a kit that exposes methods to:

  • query all NFTs held on an Interchain Account
  • query all NFTs from a specific Class held on an Interchain Account
  • transfer the NFT to other address in that chain

In order to implement the methods above, it is necessary to:

  • convert the NFT into an ERTP asset
  • map a defined denom that identifies the Class and host chain with the local Issuer and Brand objects

Note: based on the commit e436743, it is reasonable to assume that the NftKit features may be implemented under the cosmosOrchestrationAccount instead of a dedicated exo-kit.

Security Considerations

To be done ...

Documentation Considerations

For a better perception of the changes implemented, we advise to generate the api spec of the Orchestration package:

yarn install && yarn build
cd packages/orchestration
yarn typedoc
open docs/index.html

At the issue #33, a description of the logic behind the changes implemented can be found with the support of diagrams.

Testing Considerations

To be done ...

Upgrade Considerations

To be done ...

Ref: #33

Note: update /packages/cosmic-proto/dist/helpers.d.ts to the following:

export declare const toRequestQueryJson: (msg: QueryBalanceRequestProtoMsg | QueryNFTsRequestProtoMsg, opts?: RequestQueryOpts) => JsonSafe<RequestQuery>;
@Jorge-Lopes Jorge-Lopes added the enhancement New feature or request label Jun 6, 2024
@Jorge-Lopes Jorge-Lopes self-assigned this Jun 6, 2024
@Jorge-Lopes Jorge-Lopes changed the title Jorge/orchestration x/nft Orchestration API support of x/nft Jun 6, 2024
@Jorge-Lopes Jorge-Lopes changed the title Orchestration API support of x/nft Orchestration API support of NFTs Jun 6, 2024
Ref: #33
Note: required to update packages/cosmic-proto/dist/helpers.d.ts file
` toRequestQueryJson: (msg: QueryBalanceRequestProtoMsg | QueryNFTsRequestProtoMsg, ...`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant