Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add color variables into icon #5

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

angelyaaaaa
Copy link
Contributor

Purpose

  • Add color variables into each icon, making user able to customize their icon colors
  • Arrange those color, make it easy to change as theme

@JorgenVatle
Copy link
Owner

Thank you, @angelyaaaaa! This is looking really good. 🙌

Just spotted a minor issue with the checkmark once the animation finishes. We're missing a circle.
You can see the preview for this pull request here: https://deploy-preview-5--vue-sweetalert-icons.netlify.app/

If you have the time to correct that for me, I'd be more than happy to get your pull request merged. 😊

@angelyaaaaa
Copy link
Contributor Author

@JorgenVatle Thanks for your response, I think I fix the problem and update the readme as well.

@JorgenVatle
Copy link
Owner

Thank you! 🙌

@JorgenVatle JorgenVatle merged commit d4c7061 into JorgenVatle:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants