Skip to content
Test,Build And Release JASM

Character Overview improved search, still not good with longer names #4

Sign in to view logs

Character Overview improved search, still not good with longer names

Character Overview improved search, still not good with longer names #4

Triggered via pull request September 5, 2023 19:56
@JorixonJorixon
opened #19
2-character-overview-uses-old-search-logic
Status Success
Total duration 2m 56s
Artifacts 1

dotnet-desktop.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
build (Release, x64): src/GIMI-ModManager.Core/Entities/GenshinCharacter.cs#L21
Nullability of reference types in type of parameter 'x' of 'bool GenshinCharacter.Equals(GenshinCharacter x, GenshinCharacter y)' doesn't match implicitly implemented member 'bool IEqualityComparer<GenshinCharacter>.Equals(GenshinCharacter? x, GenshinCharacter? y)' (possibly because of nullability attributes).
build (Release, x64): src/GIMI-ModManager.Core/Entities/GenshinCharacter.cs#L21
Nullability of reference types in type of parameter 'y' of 'bool GenshinCharacter.Equals(GenshinCharacter x, GenshinCharacter y)' doesn't match implicitly implemented member 'bool IEqualityComparer<GenshinCharacter>.Equals(GenshinCharacter? x, GenshinCharacter? y)' (possibly because of nullability attributes).
build (Release, x64): src/GIMI-ModManager.Core/Helpers/Json.cs#L9
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L14
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L19
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L33
Dereference of a possibly null reference.
build (Release, x64): src/GIMI-ModManager.WinUI/Views/CharactersPage.xaml.cs#L22
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, x64): src/GIMI-ModManager.WinUI/Helpers/SettingsStorageExtensions.cs#L21
Possible null reference argument for parameter 'value' in 'Task<string> Json.StringifyAsync(object value)'.
build (Release, x64): src/GIMI-ModManager.WinUI/Helpers/SettingsStorageExtensions.cs#L41
Possible null reference argument for parameter 'value' in 'Task<string> Json.StringifyAsync(object value)'.
build (Release, x64): src/GIMI-ModManager.WinUI/Views/CharacterDetailsPage.xaml.cs#L308
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
build (Release, x64): src/GIMI-ModManager.Core/Entities/GenshinCharacter.cs#L21
Nullability of reference types in type of parameter 'x' of 'bool GenshinCharacter.Equals(GenshinCharacter x, GenshinCharacter y)' doesn't match implicitly implemented member 'bool IEqualityComparer<GenshinCharacter>.Equals(GenshinCharacter? x, GenshinCharacter? y)' (possibly because of nullability attributes).
build (Release, x64): src/GIMI-ModManager.Core/Entities/GenshinCharacter.cs#L21
Nullability of reference types in type of parameter 'y' of 'bool GenshinCharacter.Equals(GenshinCharacter x, GenshinCharacter y)' doesn't match implicitly implemented member 'bool IEqualityComparer<GenshinCharacter>.Equals(GenshinCharacter? x, GenshinCharacter? y)' (possibly because of nullability attributes).
build (Release, x64): src/GIMI-ModManager.Core/Helpers/Json.cs#L9
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L14
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L19
Possible null reference return.
build (Release, x64): src/GIMI-ModManager.Core/Services/FileService.cs#L33
Dereference of a possibly null reference.

Artifacts

Produced during runtime
Name Size
Upload JASM Expired
20 MB